Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1877803002: Rename ArcApplicationPolicy to ArcPolicy (Closed)

Created:
4 years, 8 months ago by bartfab (slow)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@managed_cros
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ArcApplicationPolicy to ArcPolicy We pass more than just app management policies to the ARC runtime. Consequently, the key that holds the data passed to ARC should have a more generic name than ArcApplicationPolicy. BUG=602197 TEST=Chrome compiles and runs TBR=asvitkine@chromium.org (Rietveld being dumb about historgrams.xml) Committed: https://crrev.com/cb18e46a2285abe0bf683ff532bd0909acef6a5e Cr-Commit-Position: refs/heads/master@{#386685}

Patch Set 1 #

Patch Set 2 : Updated histograms.xml #

Total comments: 2

Patch Set 3 : Reverted formatting changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M chrome/browser/chromeos/arc/arc_policy_bridge.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
bartfab (slow)
Hi Hidehiko, could you take a look at: chrome/browser/chromeos/arc/arc_policy_bridge.* Hi Alexei, could you take a ...
4 years, 8 months ago (2016-04-11 09:10:30 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-11 15:00:36 UTC) #3
hidehiko
LGTM for arc dir. Could you make the TEST= line a bit more descriptive? https://codereview.chromium.org/1877803002/diff/20001/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc ...
4 years, 8 months ago (2016-04-12 06:55:42 UTC) #4
bartfab (slow)
https://codereview.chromium.org/1877803002/diff/20001/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc File chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc (right): https://codereview.chromium.org/1877803002/diff/20001/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc#newcode87 chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc:87: "}]," On 2016/04/12 06:55:42, hidehiko wrote: > nit: indent ...
4 years, 8 months ago (2016-04-12 13:28:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877803002/40001
4 years, 8 months ago (2016-04-12 13:30:29 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-12 14:42:20 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:44:55 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb18e46a2285abe0bf683ff532bd0909acef6a5e
Cr-Commit-Position: refs/heads/master@{#386685}

Powered by Google App Engine
This is Rietveld 408576698