Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp - Issue 18778002: Inherit EventTarget interface instead of duplicating its code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

Issue 18778002: Inherit EventTarget interface instead of duplicating its code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

diff --git a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

index 10ca93f0254dc0d30a6d40a846670b81dac52ba6..8a342766c2d67518566b1e2140246a56554594ea 100644

--- a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

+++ b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

@@ -120,7 +120,7 @@ void V8CustomElementLifecycleCallbacks::created(Element* element)

v8::Context::Scope scope(context);

v8::Isolate* isolate = context->GetIsolate();

- v8::Handle<v8::Object> receiver = DOMDataStore::current(isolate)->get(element);

+ v8::Handle<v8::Object> receiver = DOMDataStore::current(isolate)->get<V8Element>(element);

if (!receiver.IsEmpty()) {

// Swizzle the prototype of the existing wrapper. We don't need to

// worry about non-existent wrappers; they will get the right

« no previous file with comments | « Source/bindings/v8/SerializedScriptValue.cpp ('k') | Source/bindings/v8/V8DOMWrapper.h » ('j') | no next file with comments »