Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1877783003: Update DisplacementMapEffect to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add more std::moves #

Patch Set 3 : Update to ToT #

Patch Set 4 : Fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -167 lines) Patch
M bench/DisplacementBench.cpp View 7 chunks +17 lines, -19 lines 0 comments Download
M bench/ImageFilterDAGBench.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M fuzz/FilterFuzz.cpp View 1 2 1 chunk +6 lines, -10 lines 0 comments Download
M gm/displacement.cpp View 1 1 chunk +77 lines, -77 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 2 3 1 chunk +6 lines, -7 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 2 chunks +21 lines, -7 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +6 lines, -10 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 2 chunks +15 lines, -12 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877783003/20001
4 years, 8 months ago (2016-04-11 15:48:35 UTC) #5
robertphillips
4 years, 8 months ago (2016-04-11 15:52:13 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 16:10:43 UTC) #8
robertphillips
ping
4 years, 8 months ago (2016-04-14 18:14:42 UTC) #9
reed1
lgtm
4 years, 8 months ago (2016-04-14 18:20:55 UTC) #10
f(malita)
lgtm
4 years, 8 months ago (2016-04-14 18:26:50 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877783003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877783003/40001
4 years, 8 months ago (2016-04-14 18:28:39 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 18:48:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877783003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877783003/40001
4 years, 8 months ago (2016-04-15 11:36:08 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/a53011ef44705a091a8e24f7ea289a3f9ad759f2
4 years, 8 months ago (2016-04-15 11:37:10 UTC) #20
robertphillips
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1884253004/ by robertphillips@google.com. ...
4 years, 8 months ago (2016-04-15 12:09:23 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877783003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877783003/60001
4 years, 8 months ago (2016-04-15 12:43:14 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 12:59:05 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877783003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877783003/60001
4 years, 8 months ago (2016-04-15 14:16:40 UTC) #29
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 14:17:40 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/bfe11fc9a6e660f83a454b6a5f5945089a4800f3

Powered by Google App Engine
This is Rietveld 408576698