METER with -webkit-appearance:none should be rendered with the normal CSS way.

METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.
  This behavior follows appearance:none defined by css-ui-4 [1].

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        CONTENT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

[1] https://www.w3.org/TR/css-ui-4/#appearance-switching

BUG=51182
Committed: https://crrev.com/5bfffca95444ba872b0a7faeaf956e92ab18639f
Cr-Commit-Position: refs/heads/master@{#390324}

[tkent, 2016-04-11 06:12:04]

Patchset #1 (id:1) has been deleted

[tkent, 2016-04-11 06:12:10]

Patchset #1 (id:20001) has been deleted

[tkent, 2016-04-11 06:22:24]

Description was changed from

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

BUG=51182
==========

to

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER
elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        SLOT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

BUG=51182
==========

[tkent, 2016-04-11 06:23:40]

tkent@chromium.org changed reviewers:
+ hayato@chromium.org, kochi@chromium.org

[tkent, 2016-04-11 06:23:41]

hayato@, kochi@, would you review this please?

After we confirm this CL is technically correct, I'll send intent-to-ship to
blink-dev.

[tkent, 2016-04-11 06:24:35]

Description was changed from

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER
elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        SLOT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

BUG=51182
==========

to

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER
elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.
  This behavior follows appearance:none defined by css-ui-4 [1].

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        SLOT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

[1] https://www.w3.org/TR/css-ui-4/#appearance-switching

BUG=51182
==========

[kochi, 2016-04-11 07:47:32]

HTMLMeterElement.cpp change lgtm

[tkent, 2016-04-14 03:41:53]

Patchset #2 (id:60001) has been deleted

[tkent, 2016-04-28 06:16:10]

Description was changed from

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER
elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.
  This behavior follows appearance:none defined by css-ui-4 [1].

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        SLOT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

[1] https://www.w3.org/TR/css-ui-4/#appearance-switching

BUG=51182
==========

to

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER
elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.
  This behavior follows appearance:none defined by css-ui-4 [1].

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        CONTENT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

[1] https://www.w3.org/TR/css-ui-4/#appearance-switching

BUG=51182
==========

[tkent, 2016-04-28 07:49:19]

On 2016/04/11 at 07:47:32, kochi wrote:
> HTMLMeterElement.cpp change lgtm

I dropped the LayoutTheme change, and added TODO comments about esprehn's advice
on blink-dev.
I think kochi-san's lgtm is enough.

API owners agreed that this change didn't need approval.


Landing.

[tkent, 2016-04-28 07:49:28]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-04-28 07:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1877763002/#ps100001
(title: "Drop LayoutTheme change, add TODO comments")

[commit-bot: I haz the power, 2016-04-28 07:49:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877763002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877763002/100001

[commit-bot: I haz the power, 2016-04-28 07:54:44]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:16:55]

Patchset 3 (id:??) landed as
https://crrev.com/5bfffca95444ba872b0a7faeaf956e92ab18639f
Cr-Commit-Position: refs/heads/master@{#390324}

[commit-bot: I haz the power, 2016-04-30 17:54:37]

Description was changed from

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER
elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.
  This behavior follows appearance:none defined by css-ui-4 [1].

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        CONTENT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

[1] https://www.w3.org/TR/css-ui-4/#appearance-switching

BUG=51182
==========

to

==========
METER with -webkit-appearance:none should be rendered with the normal CSS way.

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER
elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.
  This behavior follows appearance:none defined by css-ui-4 [1].

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        CONTENT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

[1] https://www.w3.org/TR/css-ui-4/#appearance-switching

BUG=51182

Committed: https://crrev.com/5bfffca95444ba872b0a7faeaf956e92ab18639f
Cr-Commit-Position: refs/heads/master@{#390324}
==========