Use token-based initialisation for the utility process MojoApplication.

Use token-based initialisation for the utility process MojoApplication.

BUG=597124
Committed: https://crrev.com/a9947c2ff694a3cbe6f646113e3372f03d2cc607
Cr-Commit-Position: refs/heads/master@{#386584}

[Anand Mistry (off Chromium), 2016-04-11 04:35:12]

amistry@chromium.org changed reviewers:
+ rockot@chromium.org

[Anand Mistry (off Chromium), 2016-04-11 04:35:12]

WDYT?

[Ken Rockot(use gerrit already), 2016-04-11 15:04:19]

lgtm pending one question

https://codereview.chromium.org/1877743002/diff/1/content/browser/mojo/mojo_a...
File content/browser/mojo/mojo_application_host.h (right):

https://codereview.chromium.org/1877743002/diff/1/content/browser/mojo/mojo_a...
content/browser/mojo/mojo_application_host.h:52: mojo::ScopedMessagePipeHandle
InitWithPipe();
Did you try simply using the token for the in-process case as well? It should
work because of this code:
https://code.google.com/p/chromium/codesearch#chromium/src/mojo/edk/system/no...

[Anand Mistry (off Chromium), 2016-04-12 00:31:13]

amistry@chromium.org changed reviewers:
+ avi@chromium.org

[Anand Mistry (off Chromium), 2016-04-12 00:31:14]

avi: because content owners.

https://codereview.chromium.org/1877743002/diff/1/content/browser/mojo/mojo_a...
File content/browser/mojo/mojo_application_host.h (right):

https://codereview.chromium.org/1877743002/diff/1/content/browser/mojo/mojo_a...
content/browser/mojo/mojo_application_host.h:52: mojo::ScopedMessagePipeHandle
InitWithPipe();
On 2016/04/11 15:04:18, Ken Rockot wrote:
> Did you try simply using the token for the in-process case as well? It should
> work because of this code:
>
https://code.google.com/p/chromium/codesearch#chromium/src/mojo/edk/system/no...

I did separate approaches after chatting with Sam who ran into ordering issues.
I tried using just token init and it seems to work (ran test 1000 times, no
failures). So I've changed to just using token init.

[Avi (use Gerrit), 2016-04-12 02:35:52]

lgtm

[Anand Mistry (off Chromium), 2016-04-12 03:27:56]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-04-12 03:27:56]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1877743002/#ps20001
(title: "Always use token init.")

[commit-bot: I haz the power, 2016-04-12 03:28:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877743002/20001

[commit-bot: I haz the power, 2016-04-12 04:28:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 04:31:06]

Description was changed from

==========
Use token-based initialisation for the utility process MojoApplication.

BUG=597124
==========

to

==========
Use token-based initialisation for the utility process MojoApplication.

BUG=597124

Committed: https://crrev.com/a9947c2ff694a3cbe6f646113e3372f03d2cc607
Cr-Commit-Position: refs/heads/master@{#386584}
==========

[commit-bot: I haz the power, 2016-04-12 04:31:08]

Patchset 2 (id:??) landed as
https://crrev.com/a9947c2ff694a3cbe6f646113e3372f03d2cc607
Cr-Commit-Position: refs/heads/master@{#386584}