Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1877733002:
Revert a part of the patch from https://crrev.com/1657483003 (Closed)
|
Created:
4 years, 8 months ago by Miyoung Shin(c) Modified:
4 years, 8 months ago CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert a part of the patch from https://crrev.com/1657483003
This is for reverting just the inherit part and keep the another core
change. We will fix a hitTest issue of a missed image with a border
radius property in a different way at crbug.com/602110.
BUG=568896
R=pdr@chromium.org, esprehn@chromium.org
Committed: https://crrev.com/b2771e8b6576240762daf8a0e5f982fe499318bc
Cr-Commit-Position: refs/heads/master@{#387436}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 27 (12 generated)
Description was changed from ========== Revert a part of the patch from https://crrev.com/1657483003 This is for reverting just the inherit part and keep the another core change. We will fix a hitTest issue of a missed image with a border radius property in a different way at crbug.com/602110. BUG=568896 R=pdr@chromium.org, esprehn@chromium.org ========== to ========== Revert a part of the patch from https://crrev.com/1657483003 This is for reverting just the inherit part and keep the another core change. We will fix a hitTest issue of a missed image with a border radius property in a different way at crbug.com/602110. BUG=568896 R=pdr@chromium.org, esprehn@chromium.org ==========
PTAL
On 2016/04/10 at 13:56:42, myid.shin wrote: > PTAL Thanks for putting this up. LGTM.
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877733002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877733002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by myid.shin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877733002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877733002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/04/13 01:32:34, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) I missed to remove "inherit" result in range-clone-contents-expected.txt. could you review it again?
The CQ bit was checked by pdr@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877733002/20001
Message was sent while issue was closed.
Description was changed from ========== Revert a part of the patch from https://crrev.com/1657483003 This is for reverting just the inherit part and keep the another core change. We will fix a hitTest issue of a missed image with a border radius property in a different way at crbug.com/602110. BUG=568896 R=pdr@chromium.org, esprehn@chromium.org ========== to ========== Revert a part of the patch from https://crrev.com/1657483003 This is for reverting just the inherit part and keep the another core change. We will fix a hitTest issue of a missed image with a border radius property in a different way at crbug.com/602110. BUG=568896 R=pdr@chromium.org, esprehn@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Revert a part of the patch from https://crrev.com/1657483003 This is for reverting just the inherit part and keep the another core change. We will fix a hitTest issue of a missed image with a border radius property in a different way at crbug.com/602110. BUG=568896 R=pdr@chromium.org, esprehn@chromium.org ========== to ========== Revert a part of the patch from https://crrev.com/1657483003 This is for reverting just the inherit part and keep the another core change. We will fix a hitTest issue of a missed image with a border radius property in a different way at crbug.com/602110. BUG=568896 R=pdr@chromium.org, esprehn@chromium.org Committed: https://crrev.com/b2771e8b6576240762daf8a0e5f982fe499318bc Cr-Commit-Position: refs/heads/master@{#387436} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b2771e8b6576240762daf8a0e5f982fe499318bc Cr-Commit-Position: refs/heads/master@{#387436} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
