Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: Source/core/page/Page.h

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaselined~ Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ScriptExecutionContext.cpp ('k') | Source/core/page/Page.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/Page.h
diff --git a/Source/core/page/Page.h b/Source/core/page/Page.h
index f0f07235cf312088e17d533386b9e3e9d5a06095..9f93136300ca255bfc3265ad5be4dd1dda3a5b10 100644
--- a/Source/core/page/Page.h
+++ b/Source/core/page/Page.h
@@ -25,6 +25,7 @@
#include "core/page/LayoutMilestones.h"
#include "core/page/PageVisibilityState.h"
#include "core/page/UseCounter.h"
+#include "core/platform/LifecycleContext.h"
#include "core/platform/Supplementable.h"
#include "core/platform/graphics/LayoutRect.h"
#include "core/platform/graphics/Region.h"
@@ -63,6 +64,7 @@ class InspectorController;
class Node;
class PageConsole;
class PageGroup;
+class PageLifecycleNotifier;
class PlatformMouseEvent;
class PluginData;
class PointerLockController;
@@ -92,7 +94,7 @@ struct ArenaSize {
size_t allocated;
};
-class Page : public Supplementable<Page> {
+class Page : public Supplementable<Page>, public LifecycleContext {
WTF_MAKE_NONCOPYABLE(Page);
friend class Settings;
public:
@@ -262,6 +264,9 @@ public:
void removeMultisamplingChangedObserver(MultisamplingChangedObserver*);
void multisamplingChanged();
+protected:
+ PageLifecycleNotifier* lifecycleNotifier();
+
private:
void initGroup();
@@ -273,6 +278,8 @@ private:
void setTimerAlignmentInterval(double);
+ virtual PassOwnPtr<LifecycleNotifier> createLifecycleNotifier() OVERRIDE;
+
OwnPtr<AutoscrollController> m_autoscrollController;
OwnPtr<Chrome> m_chrome;
OwnPtr<DragCaretController> m_dragCaretController;
« no previous file with comments | « Source/core/dom/ScriptExecutionContext.cpp ('k') | Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698