Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: Source/core/dom/ContextLifecycleObserver.cpp

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use SimpleLifecycleObserver in addObserver / removeObserver. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ContextLifecycleObserver.cpp
diff --git a/Source/core/dom/ContextLifecycleObserver.cpp b/Source/core/dom/ContextLifecycleObserver.cpp
index 656f54e247681a3801ccc64453bbb68c7ee45ce3..833957b2d70f7ddc8e7e30dcf5a0732ba6408260 100644
--- a/Source/core/dom/ContextLifecycleObserver.cpp
+++ b/Source/core/dom/ContextLifecycleObserver.cpp
@@ -32,7 +32,8 @@
namespace WebCore {
ContextLifecycleObserver::ContextLifecycleObserver(ScriptExecutionContext* scriptExecutionContext, Type type)
- : m_scriptExecutionContext(0)
+ : SimpleLifecycleObserver(scriptExecutionContext)
+ , m_scriptExecutionContext(0)
{
observeContext(scriptExecutionContext, type);
}
@@ -43,24 +44,11 @@ ContextLifecycleObserver::~ContextLifecycleObserver()
observeContext(0, GenericType);
}
-void ContextLifecycleObserver::observeContext(ScriptExecutionContext* scriptExecutionContext, Type as)
-{
- if (m_scriptExecutionContext) {
- ASSERT(m_scriptExecutionContext->isContextThread());
- m_scriptExecutionContext->wasUnobservedBy(this, as);
- }
-
- m_scriptExecutionContext = scriptExecutionContext;
-
- if (m_scriptExecutionContext) {
- ASSERT(m_scriptExecutionContext->isContextThread());
- m_scriptExecutionContext->wasObservedBy(this, as);
- }
-}
-
void ContextLifecycleObserver::contextDestroyed()
{
m_scriptExecutionContext = 0;
+
+ SimpleLifecycleObserver::contextDestroyed();
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698