Source/core/dom/Document.h - Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.h

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Ensure m_scriptExecutionContext is maintained and not just null. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.h

diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h

index 260a82307499ca8669b9e9e76bf570eeb1cedba8..09dac18cb7ff6fc257fff2a9791f18b473247307 100644

--- a/Source/core/dom/Document.h

+++ b/Source/core/dom/Document.h

@@ -1101,7 +1101,7 @@ private:

virtual void refScriptExecutionContext() { ref(); }

virtual void derefScriptExecutionContext() { deref(); }

- virtual PassOwnPtr<ContextLifecycleNotifier> createLifecycleNotifier() OVERRIDE;

+ virtual PassOwnPtr<LifecycleNotifier> createLifecycleNotifier() OVERRIDE;

virtual const KURL& virtualURL() const; // Same as url(), but needed for ScriptExecutionContext to implement it without a performance loss for direct calls.

virtual KURL virtualCompleteURL(const String&) const; // Same as completeURL() for the same reason as above.

« Source/core/dom/ContextLifecycleNotifier.h ('K') | « Source/core/dom/ContextLifecycleObserver.cpp ('k') | Source/core/dom/Document.cpp » ('j') | Source/core/dom/LifecycleNotifier.h » ('J')