Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: Source/core/dom/SimpleLifecycleObserver.cpp

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use SimpleLifecycleObserver in addObserver / removeObserver. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 * 24 *
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/dom/ContextLifecycleObserver.h" 28 #include "core/dom/SimpleLifecycleObserver.h"
29 29
30 #include "core/dom/ScriptExecutionContext.h" 30 #include "core/dom/SimpleLifecycleContext.h"
31 31
32 namespace WebCore { 32 namespace WebCore {
33 33
34 ContextLifecycleObserver::ContextLifecycleObserver(ScriptExecutionContext* scrip tExecutionContext, Type type) 34 SimpleLifecycleObserver::SimpleLifecycleObserver(SimpleLifecycleContext* simpleL ifecycleContext, Type type)
35 : m_scriptExecutionContext(0) 35 : m_simpleLifecycleContext(0)
36 { 36 {
37 observeContext(scriptExecutionContext, type); 37 observeContext(simpleLifecycleContext, type);
38 } 38 }
39 39
40 ContextLifecycleObserver::~ContextLifecycleObserver() 40 SimpleLifecycleObserver::~SimpleLifecycleObserver()
41 { 41 {
42 if (m_scriptExecutionContext) 42 if (m_simpleLifecycleContext)
43 observeContext(0, GenericType); 43 observeContext(0, GenericType);
44 } 44 }
45 45
46 void ContextLifecycleObserver::observeContext(ScriptExecutionContext* scriptExec utionContext, Type as) 46 void SimpleLifecycleObserver::observeContext(SimpleLifecycleContext* context, Ty pe type)
47 { 47 {
48 if (m_scriptExecutionContext) { 48 if (m_simpleLifecycleContext) {
49 ASSERT(m_scriptExecutionContext->isContextThread()); 49 ASSERT(m_simpleLifecycleContext->isContextThread());
50 m_scriptExecutionContext->wasUnobservedBy(this, as); 50 m_simpleLifecycleContext->wasUnobservedBy(this, type);
51 } 51 }
52 52
53 m_scriptExecutionContext = scriptExecutionContext; 53 m_simpleLifecycleContext = context;
54 54
55 if (m_scriptExecutionContext) { 55 if (m_simpleLifecycleContext) {
56 ASSERT(m_scriptExecutionContext->isContextThread()); 56 ASSERT(m_simpleLifecycleContext->isContextThread());
57 m_scriptExecutionContext->wasObservedBy(this, as); 57 m_simpleLifecycleContext->wasObservedBy(this, type);
58 } 58 }
59 } 59 }
60 60
61 void ContextLifecycleObserver::contextDestroyed() 61 void SimpleLifecycleObserver::contextDestroyed()
62 { 62 {
63 m_scriptExecutionContext = 0; 63 m_simpleLifecycleContext = 0;
64 } 64 }
65 65
66 } // namespace WebCore 66 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698