components/font_service/public/interfaces/font_service.mojom - Issue 1877673002: Move legacyCreateTypeface to SkFontStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/font_service/public/interfaces/font_service.mojom

Issue 1877673002: Move legacyCreateTypeface to SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, update Skia change. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/font_service/public/interfaces/font_service.mojom

diff --git a/components/font_service/public/interfaces/font_service.mojom b/components/font_service/public/interfaces/font_service.mojom

index 3d53b0007f30616b9eadd31754ebc1fce7ac1aef..acbbafa7a93716c61d4af9a351be6d345b7476c4 100644

--- a/components/font_service/public/interfaces/font_service.mojom

+++ b/components/font_service/public/interfaces/font_service.mojom

@@ -4,11 +4,14 @@

module font_service;

-enum TypefaceStyle {

- NORMAL = 0,

- BOLD = 0x01,

- ITALIC = 0x02,

- BOLD_ITALIC = 0x03

+enum TypefaceSlant {

+ ROMAN = 0,

+ ITALIC = 1,

+};

+struct TypefaceStyle {

Elliot Glaysher 2016/04/11 18:04:41 one line of whitespace between the enum and the st

bungeman-chromium 2016/04/11 18:29:22 Done.

+ uint16 weight;

+ uint8 width;

+ TypefaceSlant slant;

};

// A reference to specific font on the font service.