content/child/font_warmup_win_unittest.cc - Issue 1877673002: Move legacyCreateTypeface to SkFontStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/font_warmup_win_unittest.cc

Issue 1877673002: Move legacyCreateTypeface to SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/font_warmup_win_unittest.cc

diff --git a/content/child/font_warmup_win_unittest.cc b/content/child/font_warmup_win_unittest.cc

index 91c0c84393c406ccd54bf73157b908c027ecd715..d6a5ae0a2c0a999e34fc34bc3d46f7c56119c235 100644

--- a/content/child/font_warmup_win_unittest.cc

+++ b/content/child/font_warmup_win_unittest.cc

@@ -200,7 +200,7 @@ class TestSkFontMgr : public SkFontMgr {

}

SkTypeface* onLegacyCreateTypeface(const char familyName[],

- unsigned styleBits) const override {

+ SkFontStyle style) const override {

ADD_FAILURE();

return nullptr;

}