[DevTools] Use plain text for network conditions menu.

third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {function(!Array<!WebInspector.NetworkConditionsGroup>):!Array<?WebInspector.NetworkManager.Conditions>} populateCallback
  * @param {function(number)} selectCallback
  */
 WebInspector.NetworkConditionsSelector = function(populateCallback, selectCallback)
 {
     this._populateCallback = populateCallback;
     this._selectCallback = selectCallback;
     this._customSetting = WebInspector.moduleSetting("customNetworkConditions");
     this._customSetting.addChangeListener(this._populateOptions, this);
     this._manager = WebInspector.multitargetNetworkManager;
     this._manager.addEventListener(WebInspector.MultitargetNetworkManager.Events.ConditionsChanged, this._conditionsChanged, this);
     this._populateOptions();
 }
 
 /** @typedef {!{title: string, items: !Array<!WebInspector.NetworkManager.Conditions>}} */
 WebInspector.NetworkConditionsGroup;
 
 /**
  * @param {number} throughput
+ * @param {boolean=} plainText
  * @return {string}
  */
-WebInspector.NetworkConditionsSelector._throughputText = function(throughput)
+WebInspector.NetworkConditionsSelector._throughputText = function(throughput, plainText)
 {
     if (throughput < 0)
         return "";
     var throughputInKbps = throughput / (1024 / 8);
+    var delimiter = plainText ? "" : " ";
     if (throughputInKbps < 1024)
-        return WebInspector.UIString("%d kb/s", throughputInKbps);
+        return WebInspector.UIString("%d%skb/s", throughputInKbps, delimiter);
     if (throughputInKbps < 1024 * 10)
-        return WebInspector.UIString("%.1f Mb/s", throughputInKbps / 1024);
-    return WebInspector.UIString("%d Mb/s", (throughputInKbps / 1024) | 0);
+        return WebInspector.UIString("%.1f%sMb/s", throughputInKbps / 1024, delimiter);
+    return WebInspector.UIString("%d%sMb/s", (throughputInKbps / 1024) | 0, delimiter);
 }
 
 /** @type {!Array.<!WebInspector.NetworkManager.Conditions>} */
 WebInspector.NetworkConditionsSelector._presets = [
     {title: "Offline", download: 0 * 1024 / 8, upload: 0 * 1024 / 8, latency: 0},
     {title: "GPRS", download: 50 * 1024 / 8, upload: 20 * 1024 / 8, latency: 500},
     {title: "Regular 2G", download: 250 * 1024 / 8, upload: 50 * 1024 / 8, latency: 300},
     {title: "Good 2G", download: 450 * 1024 / 8, upload: 150 * 1024 / 8, latency: 150},
     {title: "Regular 3G", download: 750 * 1024 / 8, upload: 250 * 1024 / 8, latency: 100},
     {title: "Good 3G", download: 1.5 * 1024 * 1024 / 8, upload: 750 * 1024 / 8, latency: 40},
     {title: "Regular 4G", download: 4 * 1024 * 1024 / 8, upload: 3 * 1024 * 1024 / 8, latency: 20},
     {title: "DSL", download: 2 * 1024 * 1024 / 8, upload: 1 * 1024 * 1024 / 8, latency: 5},
     {title: "WiFi", download: 30 * 1024 * 1024 / 8, upload: 15 * 1024 * 1024 / 8, latency: 2}
 ];
 
 /**
  * @param {!WebInspector.NetworkManager.Conditions} conditions
+ * @param {boolean=} plainText
  * @return {!{text: string, title: string}}
  */
-WebInspector.NetworkConditionsSelector._conditionsTitle = function(conditions)
+WebInspector.NetworkConditionsSelector._conditionsTitle = function(conditions, plainText)
 {
     var downloadInKbps = conditions.download / (1024 / 8);
     var uploadInKbps = conditions.upload / (1024 / 8);
     var isThrottling = (downloadInKbps >= 0) || (uploadInKbps >= 0) || (conditions.latency > 0);
     var conditionTitle = WebInspector.UIString(conditions.title);
     if (!isThrottling)
         return {text: conditionTitle, title: conditionTitle};
 
-    var downloadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.download);
-    var uploadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.upload);
-    var title = WebInspector.UIString("%s (%s\u2b07 %s\u2b06 %dms RTT)", conditionTitle, downloadText, uploadText, conditions.latency);
+    var downloadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.download, plainText);
+    var uploadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.upload, plainText);
+    var pattern = plainText ? "%s (%dms, %s, %s)" : "%s (%dms RTT, %s\u2b07, %s\u2b06)";
+    var title = WebInspector.UIString(pattern, conditionTitle, conditions.latency, downloadText, uploadText);
     return {text: title, title: WebInspector.UIString("Maximum download throughput: %s.\r\nMaximum upload throughput: %s.\r\nMinimum round-trip time: %dms.", downloadText, uploadText, conditions.latency)};
 }
 
 WebInspector.NetworkConditionsSelector.prototype = {
     _populateOptions: function()
     {
         var customGroup = {title: WebInspector.UIString("Custom"), items: this._customSetting.get()};
         var presetsGroup = {title: WebInspector.UIString("Presets"), items: WebInspector.NetworkConditionsSelector._presets};
         var disabledGroup = {title: WebInspector.UIString("Disabled"), items: [WebInspector.NetworkManager.NoThrottlingConditions]};
         this._options = this._populateCallback([customGroup, presetsGroup, disabledGroup]);
@@ skipping 99 matching lines @@
     /**
      * @param {!WebInspector.ContextMenu} contextMenu
      */
     function appendItems(contextMenu)
     {
         for (var index = 0; index < options.length; ++index) {
             var conditions = options[index];
             if (!conditions)
                 contextMenu.appendSeparator();
             else
-                contextMenu.appendCheckboxItem(WebInspector.NetworkConditionsSelector._conditionsTitle(conditions).text, selector.optionSelected.bind(selector, conditions), selectedIndex === index);
+                contextMenu.appendCheckboxItem(WebInspector.NetworkConditionsSelector._conditionsTitle(conditions, true).text, selector.optionSelected.bind(selector, conditions), selectedIndex === index);
         }
         contextMenu.appendItem(WebInspector.UIString("Edit\u2026"), selector.revealAndUpdate.bind(selector));
     }
 
     /**
      * @param {!Array.<!WebInspector.NetworkConditionsGroup>} groups
      * @return {!Array<?WebInspector.NetworkManager.Conditions>}
      */
     function populate(groups)
     {
@@ skipping 217 matching lines @@
          */
         function latencyValidator(item, index, input)
         {
             var value = input.value.trim();
             return !value || (/^[\d]+$/.test(value) && value >= 0 && value <= 1000000);
         }
     },
 
     __proto__: WebInspector.VBox.prototype
 }