Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1877553002: Avoid copying in TrimRight() and TrimLeft() if possible. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid copying in TrimRight() and TrimLeft() if possible. Make Byte and Wide code identical while at it. Committed: https://pdfium.googlesource.com/pdfium/+/184b82553000a41fd0c90be56fa2f1c1503e2e9e

Patch Set 1 #

Patch Set 2 : More accurate comment in fx_string.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -18 lines) Patch
M core/fxcrt/fx_basic_bstring.cpp View 4 chunks +2 lines, -2 lines 0 comments Download
M core/fxcrt/fx_basic_bstring_unittest.cpp View 2 chunks +62 lines, -0 lines 0 comments Download
M core/fxcrt/fx_basic_wstring.cpp View 3 chunks +13 lines, -10 lines 0 comments Download
M core/fxcrt/fx_basic_wstring_unittest.cpp View 2 chunks +62 lines, -0 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-08 21:30:00 UTC) #2
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-08 21:31:01 UTC) #3
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-08 21:49:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877553002/20001
4 years, 8 months ago (2016-04-11 17:37:24 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 17:56:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/184b82553000a41fd0c90be56fa2f1c1503e...

Powered by Google App Engine
This is Rietveld 408576698