ash/wm/panels/panel_window_resizer.cc - Issue 1877543002: Revise the shelf alignment locking mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/panels/panel_window_resizer.cc

Issue 1877543002: Revise the shelf alignment locking mechanism. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move logic to a new ShelfLockingManager, owned by Shelf. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/panels/panel_window_resizer.cc

diff --git a/ash/wm/panels/panel_window_resizer.cc b/ash/wm/panels/panel_window_resizer.cc

index 501503ad7b52905b1680b95a1d6963e0c19805ca..3b9e4eef78550ed6e22decbf440123580eaa0994 100644

--- a/ash/wm/panels/panel_window_resizer.cc

+++ b/ash/wm/panels/panel_window_resizer.cc

@@ -140,6 +140,7 @@ bool PanelWindowResizer::AttachToLauncher(const gfx::Rect& bounds,

shelf_widget()->GetWindowBoundsInScreen());

switch (panel_layout_manager->shelf()->alignment()) {

case SHELF_ALIGNMENT_BOTTOM:

+ case SHELF_ALIGNMENT_LOCKED:

if (bounds.bottom() >= (launcher_bounds.y() -

kPanelSnapToLauncherDistance)) {

should_attach = true;