Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2336)

Unified Diff: ash/shelf/shelf_layout_manager_unittest.cc

Issue 1877543002: Revise the shelf alignment locking mechanism. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move logic to a new ShelfLockingManager, owned by Shelf. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_layout_manager_unittest.cc
diff --git a/ash/shelf/shelf_layout_manager_unittest.cc b/ash/shelf/shelf_layout_manager_unittest.cc
index 1f97dcb447039325f509db352efbd8ffdff3fb30..1a0f5da63a0481b93a2c0ee40e4068708c3f9dc1 100644
--- a/ash/shelf/shelf_layout_manager_unittest.cc
+++ b/ash/shelf/shelf_layout_manager_unittest.cc
@@ -381,10 +381,12 @@ class ShelfLayoutManagerTest : public ash::test::AshTestBase {
// Open the add user screen if |show| is true, otherwise end it.
void ShowAddUserScreen(bool show) {
SetUserAddingScreenRunning(show);
- ShelfLayoutManager* manager = GetShelfWidget()->shelf_layout_manager();
- manager->SessionStateChanged(
- show ? SessionStateDelegate::SESSION_STATE_LOGIN_SECONDARY :
- SessionStateDelegate::SESSION_STATE_ACTIVE);
+
+ const SessionStateDelegate::SessionState state =
+ show ? SessionStateDelegate::SESSION_STATE_LOGIN_SECONDARY
+ : SessionStateDelegate::SESSION_STATE_ACTIVE;
+ GetShelfWidget()->shelf_layout_manager()->SessionStateChanged(state);
+ GetShelfWidget()->shelf()->SessionStateChanged(state);
}
private:
@@ -764,7 +766,7 @@ TEST_F(ShelfLayoutManagerTest, SideAlignmentInteractionWithLockScreen) {
manager->SetAlignment(SHELF_ALIGNMENT_LEFT);
EXPECT_EQ(SHELF_ALIGNMENT_LEFT, manager->GetAlignment());
LockScreen();
- EXPECT_EQ(SHELF_ALIGNMENT_BOTTOM, manager->GetAlignment());
+ EXPECT_EQ(SHELF_ALIGNMENT_LOCKED, manager->GetAlignment());
UnlockScreen();
EXPECT_EQ(SHELF_ALIGNMENT_LEFT, manager->GetAlignment());
}
@@ -775,7 +777,7 @@ TEST_F(ShelfLayoutManagerTest, SideAlignmentInteractionWithAddUserScreen) {
manager->SetAlignment(SHELF_ALIGNMENT_LEFT);
EXPECT_EQ(SHELF_ALIGNMENT_LEFT, manager->GetAlignment());
ShowAddUserScreen(true);
- EXPECT_EQ(SHELF_ALIGNMENT_BOTTOM, manager->GetAlignment());
+ EXPECT_EQ(SHELF_ALIGNMENT_LOCKED, manager->GetAlignment());
ShowAddUserScreen(false);
EXPECT_EQ(SHELF_ALIGNMENT_LEFT, manager->GetAlignment());
}

Powered by Google App Engine
This is Rietveld 408576698