Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: build/config/ios/ios_sdk.gni

Issue 1877523002: Mac/iOS/GN: Generate Info.plist files for Mac apps and frameworks with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete version information to be populated elsewhere, fix assert string. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/ios_gen_plist.py ('k') | build/config/ios/ios_sdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/ios_sdk.gni
diff --git a/build/config/ios/ios_sdk.gni b/build/config/ios/ios_sdk.gni
index 7a648d3d9498e81ebd6281ea55df739da1d74f17..31885e77c282b0796950cd7896f386c72233b478 100644
--- a/build/config/ios/ios_sdk.gni
+++ b/build/config/ios/ios_sdk.gni
@@ -34,10 +34,11 @@ if (ios_sdk_path == "") {
ios_sdk_name = "iphoneos"
ios_sdk_platform = "iPhoneOS"
}
- _ios_sdk_result = exec_script("ios_sdk.py", [ ios_sdk_name ], "scope")
- ios_sdk_path = _ios_sdk_result.ios_sdk_path
- ios_sdk_version = _ios_sdk_result.ios_sdk_version
- ios_sdk_build = _ios_sdk_result.ios_sdk_build
+ _ios_sdk_result =
+ exec_script("//build/config/mac/sdk_info.py", [ ios_sdk_name ], "scope")
+ ios_sdk_path = _ios_sdk_result.sdk_path
+ ios_sdk_version = _ios_sdk_result.sdk_version
+ ios_sdk_build = _ios_sdk_result.sdk_build
xcode_version = _ios_sdk_result.xcode_version
xcode_build = _ios_sdk_result.xcode_build
machine_os_build = _ios_sdk_result.machine_os_build
@@ -66,7 +67,7 @@ if (ios_enable_code_signing) {
if (ios_code_signing_identity == "") {
print("Tried to prepare a device build without specifying a code signing")
print("identity and could not detect one automatically either.")
- print("TIP: Simulator builds dont require code signing...")
+ print("TIP: Simulator builds don't require code signing...")
assert(false)
}
}
« no previous file with comments | « build/config/ios/ios_gen_plist.py ('k') | build/config/ios/ios_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698