Mac/iOS/GN: Generate Info.plist files for Mac apps and frameworks with gn.

build/config/ios/rules.gni

Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 5d5e2733ad2adea26209678c6c26786a46f973f7..d6148c59b1fd46d6c61b80b4b3504b1d68b2d43b 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -5,6 +5,34 @@
 import("//build/config/ios/ios_sdk.gni")
 import("//build/config/mac/rules.gni")
 
+template("ios_info_plist") {
+  assert(defined(invoker.info_plist),

[Robert Sesek, 2016/04/21 15:36:21]

I think you can rely on the asserts in the info_plist template to handle this.

[Patti Lor, 2016/04/22 02:49:55]

Done.

+         "The Info.plist file must be specified for $target_name")
+  assert(defined(invoker._output_name),
+         "The output_name file must be specified for $target_name")
+
+  info_plist(target_name) {
+    extra_substitutions = []
+    if (defined(invoker.extra_substitutions)) {
+      extra_substitutions = invoker.extra_substitutions
+    }
+    extra_substitutions += [
+      "IOS_DEPLOYMENT_TARGET=$ios_deployment_target",
+      "IOS_PLATFORM_BUILD=$ios_platform_build",
+      "IOS_PLATFORM_NAME=$ios_sdk_name",
+      "IOS_PLATFORM_VERSION=$ios_sdk_version",
+      "IOS_SDK_BUILD=$ios_sdk_build",
+      "IOS_SDK_NAME=$ios_sdk_name$ios_sdk_version",
+      "IOS_SUPPORTED_PLATFORM=$ios_sdk_platform",
+    ]
+    plist_templates = [
+      "//build/config/ios/BuildInfo.plist",
+      invoker.info_plist,
+    ]
+    forward_variables_from(invoker, [ "_output_name" ])
+  }
+}
+
 # TODO(crbug.com/297668): refactor this template to extract common behaviour
 # between OS X and iOS bundle generation, then create a generic "app" template
 # that forward to "executable" on all platform except iOS/OS X.
@@ -45,40 +73,13 @@ template("ios_app_bundle") {
   _generate_info_plist = target_name + "_generate_info_plist"
   _bundle_data_info_plist = target_name + "_bundle_data_info_plist"
 
-  action(_generate_info_plist) {
-    visibility = [ ":$_bundle_data_info_plist" ]
-    script = "//build/config/ios/ios_gen_plist.py"
-    sources = [
-      "//build/config/ios/BuildInfo.plist",
-      invoker.info_plist,
-    ]
-    outputs = [
-      "$target_gen_dir/$target_name/Info.plist",
-    ]
-    extra_args = []
-    if (defined(invoker.extra_substitutions)) {
-      foreach(substitution, invoker.extra_substitutions) {
-        extra_args += [ "-s=$substitution" ]
-      }
-    }
-    response_file_contents =
-        extra_args + [
-          "-s=BUILD_MACHINE_OS_BUILD=$machine_os_build",
-          "-s=EXECUTABLE_NAME=$_output_name",
-          "-s=GCC_VERSION=com.apple.compilers.llvm.clang.1_0",
-          "-s=IOS_DEPLOYMENT_TARGET=$ios_deployment_target",
-          "-s=IOS_PLATFORM_BUILD=$ios_platform_build",
-          "-s=IOS_PLATFORM_NAME=$ios_sdk_name",
-          "-s=IOS_PLATFORM_VERSION=$ios_sdk_version",
-          "-s=IOS_SDK_BUILD=$ios_sdk_build",
-          "-s=IOS_SDK_NAME=$ios_sdk_name$ios_sdk_version",
-          "-s=IOS_SUPPORTED_PLATFORM=$ios_sdk_platform",
-          "-s=PRODUCT_NAME=$_output_name",
-          "-s=XCODE_BUILD=$xcode_build",
-          "-s=XCODE_VERSION=$xcode_version",
-          "-o=" + rebase_path(outputs[0], root_out_dir),
-        ] + rebase_path(sources, root_out_dir)
-    args = [ "@{{response_file_name}}" ]
+  ios_info_plist(_generate_info_plist) {
+    forward_variables_from(invoker,
+                           [
+                             "extra_substitutions",
+                             "info_plist",
+                             "_output_name",
+                           ])
   }
 
   bundle_data(_bundle_data_info_plist) {