Replace libusb in the Linux/Chrome OS USB I/O path.

device/usb/usb_device_handle_usbfs.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DEVICE_USB_USB_DEVICE_HANDLE_USBFS_H_
+#define DEVICE_USB_USB_DEVICE_HANDLE_USBFS_H_
+
+#include <list>
+#include <map>
+#include <vector>
+
+#include "base/files/scoped_file.h"
+#include "device/usb/usb_device_handle.h"
+
+struct usbdevfs_urb;
+
+namespace base {
+class SequencedTaskRunner;
+}
+
+namespace device {
+
+// Implementation of a USB device handle on top of the Linux USBFS ioctl
+// interface available on Linux, Chrome OS and Android.
+class UsbDeviceHandleUsbfs : public UsbDeviceHandle {
+ public:
+  // Constructs a new device handle from an existing |device| and open file
+  // descriptor to that device. |blocking_task_runner| must have a
+  // MessageLoopForIO.
+  UsbDeviceHandleUsbfs(
+      scoped_refptr<UsbDevice> device,
+      base::ScopedFD fd,
+      scoped_refptr<base::SequencedTaskRunner> blocking_task_runner);
+
+  // UsbDeviceHandle implementation.

[juncai, 2016/04/13 00:22:32]

nit:
s/UsbDeviceHandle implementation./UsbDeviceHandle:

Noticed usb_device_handle_usbfs.cc uses this kind of comment style for virtual
functions.

[Reilly Grant (use Gerrit), 2016/04/13 20:21:13]

We're not very consistent about this in Chromium. I like the more verbose
version.

[juncai, 2016/04/13 23:52:12]

nit: s/implementation/overrides
To be consistent, noticed usb_device_handle_usbfs.cc uses "overrides" instead of
"implementation".

[Reilly Grant (use Gerrit), 2016/04/14 00:02:45]

We discussed this offline and I explained the reason for differentiating between
an "implementation" (UsbDeviceHandleUsbfs implements UsbDeviceHandle's abstract
interface) and an "override" (FileThreadHelper overrides some event handlers in
the observers it subclasses).

+  scoped_refptr<UsbDevice> GetDevice() const override;
+  void Close() override;
+  void SetConfiguration(int configuration_value,
+                        const ResultCallback& callback) override;
+  void ClaimInterface(int interface_number,
+                      const ResultCallback& callback) override;
+  void ReleaseInterface(int interface_number,
+                        const ResultCallback& callback) override;
+  void SetInterfaceAlternateSetting(int interface_number,
+                                    int alternate_setting,
+                                    const ResultCallback& callback) override;
+  void ResetDevice(const ResultCallback& callback) override;
+  void ClearHalt(uint8_t endpoint, const ResultCallback& callback) override;
+  void ControlTransfer(UsbEndpointDirection direction,
+                       TransferRequestType request_type,
+                       TransferRecipient recipient,
+                       uint8_t request,
+                       uint16_t value,
+                       uint16_t index,
+                       scoped_refptr<net::IOBuffer> buffer,
+                       size_t length,
+                       unsigned int timeout,
+                       const TransferCallback& callback) override;
+  void IsochronousTransferIn(
+      uint8_t endpoint_number,
+      const std::vector<uint32_t>& packet_lengths,
+      unsigned int timeout,
+      const IsochronousTransferCallback& callback) override;
+
+  void IsochronousTransferOut(
+      uint8_t endpoint_number,
+      scoped_refptr<net::IOBuffer> buffer,
+      const std::vector<uint32_t>& packet_lengths,
+      unsigned int timeout,
+      const IsochronousTransferCallback& callback) override;
+  void GenericTransfer(UsbEndpointDirection direction,
+                       uint8_t endpoint_number,
+                       scoped_refptr<net::IOBuffer> buffer,
+                       size_t length,
+                       unsigned int timeout,
+                       const TransferCallback& callback) override;
+  const UsbInterfaceDescriptor* FindInterfaceByEndpoint(
+      uint8_t endpoint_address) override;
+
+ private:
+  class FileThreadHelper;
+  struct Transfer;
+  struct InterfaceInfo {
+    uint8_t alternate_setting;
+  };
+  struct EndpointInfo {
+    UsbTransferType type;
+    const UsbInterfaceDescriptor* interface;
+  };
+
+  ~UsbDeviceHandleUsbfs() override;
+  void CloseBlocking();
+  void SetConfigurationBlocking(int configuration_value,
+                                const ResultCallback& callback);
+  void SetConfigurationComplete(int configuration_value,
+                                bool success,
+                                const ResultCallback& callback);
+  void ReleaseInterfaceBlocking(int interface_number,
+                                const ResultCallback& callback);
+  void ReleaseInterfaceComplete(int interface_number,
+                                const ResultCallback& callback);
+  void SetInterfaceBlocking(int interface_number,
+                            int alternate_setting,
+                            const ResultCallback& callback);
+  void ResetDeviceBlocking(const ResultCallback& callback);
+  void ClearHaltBlocking(uint8_t endpoint_address,
+                         const ResultCallback& callback);
+  void IsochronousTransferInternal(uint8_t endpoint_address,
+                                   scoped_refptr<net::IOBuffer> buffer,
+                                   int length,
+                                   const std::vector<uint32_t>& packet_lengths,
+                                   unsigned int timeout,
+                                   const IsochronousTransferCallback& callback);
+  void ReapedUrbs(std::vector<struct usbdevfs_urb*> urbs);

[juncai, 2016/04/13 00:22:33]

The "struct" may be omitted.

Also here the parameter can be:
const std::vector<struct usbdevfs_urb*>&
to avoid copying.

[Reilly Grant (use Gerrit), 2016/04/13 20:21:13]

Done.

+  void TransferComplete(scoped_ptr<Transfer> transfer);
+  void RefreshEndpointInfo();
+  void ReportIsochronousError(
+      const std::vector<uint32_t> packet_lengths,

[juncai, 2016/04/13 00:22:33]

Use const std::vector<uint32_t>& as parameter?

[Reilly Grant (use Gerrit), 2016/04/13 20:21:13]

Good catch.

+      const UsbDeviceHandle::IsochronousTransferCallback& callback,
+      UsbTransferStatus status);
+  void SetUpTimeoutCallback(Transfer* transfer, unsigned int timeout);
+
+  static void TransferTimedOut(Transfer* transfer);
+
+  scoped_refptr<UsbDevice> device_;
+  base::ScopedFD fd_;
+  scoped_refptr<base::SequencedTaskRunner> task_runner_;
+  scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
+  base::ThreadChecker thread_checker_;
+
+  // Maps claimed interfaces by interface number to their current alternate
+  // setting.
+  std::map<uint8_t, InterfaceInfo> interfaces_;

[juncai, 2016/04/13 00:22:33]

The type of interface number is int elsewhere. Here it is uint8_t.

[Reilly Grant (use Gerrit), 2016/04/13 20:21:13]

The type is int when a "not found" value (-1) is required. The proper type for
an interface number is uint8_t.

+
+  // Maps endpoints (by endpoint address) to the interface they are a part of.
+  // Only endpoints of currently claimed and selected interface alternates are
+  // included in the map.
+  std::map<uint8_t, EndpointInfo> endpoints_;
+
+  // Helper object owned by the blocking task thread. I will be freed if that

[juncai, 2016/04/13 00:22:32]

s/I/It/

[Reilly Grant (use Gerrit), 2016/04/13 20:21:13]

Done.

[Reilly Grant (use Gerrit), 2016/04/13 20:21:13]

Done.

+  // thread's message loop is destroyed but can also be freed by this class on
+  // destruction.
+  FileThreadHelper* helper_;
+
+  std::list<scoped_ptr<Transfer>> transfers_;
+};
+
+}  // namespace device
+
+#endif  // DEVICE_USB_USB_DEVICE_HANDLE_USBFS_H_