Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1877413004:
Revert "Ignore WebViewPlatformBridge apk when merging apks" (Closed)
|
Created:
4 years, 8 months ago by paulmiller Modified:
4 years, 8 months ago Reviewers:
sgurun-gerrit only CC:
chromium-reviews, android-webview-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert "Ignore WebViewPlatformBridge apk when merging apks"
This reverts commit fd17f011bbafa4e6e5e98e616a1cbf1a6580f968.
BUG=580678
BUG=602768
Committed: https://crrev.com/cf3df483a780df28a47c4a70ef9c6311e7c3753b
Cr-Commit-Position: refs/heads/master@{#387066}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Revert "Ignore WebViewPlatformBridge apk when merging apks" This reverts commit fd17f011bbafa4e6e5e98e616a1cbf1a6580f968. BUG=580678 BUG=602768 ========== to ========== Revert "Ignore WebViewPlatformBridge apk when merging apks" This reverts commit fd17f011bbafa4e6e5e98e616a1cbf1a6580f968. BUG=580678 BUG=602768 ==========
paulmiller@chromium.org changed reviewers: + sgurun@chromium.org
On 2016/04/12 23:25:00, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:sgurun@chromium.org PTAL
On 2016/04/12 23:25:17, paulmiller wrote: > On 2016/04/12 23:25:00, paulmiller wrote: > > mailto:paulmiller@chromium.org changed reviewers: > > + mailto:sgurun@chromium.org > > PTAL lgtm
The CQ bit was checked by paulmiller@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877413004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patch failure. Weird, since that part of the file hasn't changed. Maybe a rebase will make it happy.
The CQ bit was checked by paulmiller@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org Link to the patchset: https://codereview.chromium.org/1877413004/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877413004/20001
Message was sent while issue was closed.
Description was changed from ========== Revert "Ignore WebViewPlatformBridge apk when merging apks" This reverts commit fd17f011bbafa4e6e5e98e616a1cbf1a6580f968. BUG=580678 BUG=602768 ========== to ========== Revert "Ignore WebViewPlatformBridge apk when merging apks" This reverts commit fd17f011bbafa4e6e5e98e616a1cbf1a6580f968. BUG=580678 BUG=602768 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Revert "Ignore WebViewPlatformBridge apk when merging apks" This reverts commit fd17f011bbafa4e6e5e98e616a1cbf1a6580f968. BUG=580678 BUG=602768 ========== to ========== Revert "Ignore WebViewPlatformBridge apk when merging apks" This reverts commit fd17f011bbafa4e6e5e98e616a1cbf1a6580f968. BUG=580678 BUG=602768 Committed: https://crrev.com/cf3df483a780df28a47c4a70ef9c6311e7c3753b Cr-Commit-Position: refs/heads/master@{#387066} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cf3df483a780df28a47c4a70ef9c6311e7c3753b Cr-Commit-Position: refs/heads/master@{#387066} |
