Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1877403004: Revert of Update V8 to version 5.2.20. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.2.20. (patchset #1 id:1 of https://codereview.chromium.org/1884913002/ ) Reason for revert: https://build.chromium.org/p/chromium.fyi/builders/WinClang/builds/205/steps/compile/logs/stdio ../../v8/src/runtime/runtime-atomics.cc(126,1): error: unused function 'LoadSeqCst' [-Werror,-Wunused-function] ATOMIC_OPS(int8_t, 8, char) ^ ../../v8/src/runtime/runtime-atomics.cc(120,15): note: expanded from macro 'ATOMIC_OPS' inline type LoadSeqCst(type* p) { return *p; } \ ^ Original issue's description: > Update V8 to version 5.2.20. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/f7a11412..d8d54ea9 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/31e492eab1deee4798c016ed4d7b306997f4dd82 > Cr-Commit-Position: refs/heads/master@{#386958} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d2de2a6ae68efabc28fa549f95e806fb510d0964 Cr-Commit-Position: refs/heads/master@{#386964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
Created Revert of Update V8 to version 5.2.20.
4 years, 8 months ago (2016-04-13 11:43:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877403004/1
4 years, 8 months ago (2016-04-13 11:43:41 UTC) #2
Nico
binji: fyi (i want to test changes today to make win_clang a default-on trybot, so ...
4 years, 8 months ago (2016-04-13 11:44:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 11:44:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d2de2a6ae68efabc28fa549f95e806fb510d0964 Cr-Commit-Position: refs/heads/master@{#386964}
4 years, 8 months ago (2016-04-13 11:45:39 UTC) #8
Michael Achenbach
4 years, 8 months ago (2016-04-13 11:59:18 UTC) #9
Message was sent while issue was closed.
I guess we also need some v8-side win-clang bots...

Powered by Google App Engine
This is Rietveld 408576698