Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 1877403003: [ast] Annotate some nodes with number of yields. (Closed)

Created:
4 years, 8 months ago by neis
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Annotate some nodes with number of yields. Annotate generator functions and loops therein with the number of contained yields. This information will eventually be used by the bytecode generator. R=bmeurer@chromium.org BUG=v8:4907 LOG=n Committed: https://crrev.com/9e99c92c22125d01da4e478dc48dc87e1b3a07bc Cr-Commit-Position: refs/heads/master@{#35439}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -17 lines) Patch
M src/ast/ast.h View 6 chunks +12 lines, -2 lines 0 comments Download
M src/ast/ast-numbering.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ast/ast-numbering.cc View 11 chunks +31 lines, -13 lines 1 comment Download
M src/ast/prettyprinter.cc View 6 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
neis
4 years, 8 months ago (2016-04-13 09:52:19 UTC) #1
neis
https://codereview.chromium.org/1877403003/diff/1/src/ast/ast-numbering.cc File src/ast/ast-numbering.cc (right): https://codereview.chromium.org/1877403003/diff/1/src/ast/ast-numbering.cc#newcode396 src/ast/ast-numbering.cc:396: Visit(node->enumerable()); // Not part of loop. Here I'm changing ...
4 years, 8 months ago (2016-04-13 09:54:27 UTC) #2
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-13 09:56:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877403003/1
4 years, 8 months ago (2016-04-13 10:18:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 10:41:45 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 10:42:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e99c92c22125d01da4e478dc48dc87e1b3a07bc
Cr-Commit-Position: refs/heads/master@{#35439}

Powered by Google App Engine
This is Rietveld 408576698