Handlify JSReceiver/JSObject::DeleteProperty method.

Handlify JSReceiver/JSObject::DeleteProperty method.

R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15730

[Toon Verwaest, 2013-07-12 12:37:34]

https://codereview.chromium.org/18774002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode716
src/objects.cc:716: Handle<NameDictionary> dictionary =
handle(object->property_dictionary());
What about just Handle<NameDictionary> dictionary(object->property_dictonary())?

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode3551
src/objects.cc:3551: return *JSProxy::DeletePropertyWithHandler(object, name,
mode);
It seems a bit scary to call from non-handlified code into handlified code. Can
we get rid of this method altogether and make its caller also handlified?

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5131
src/objects.cc:5131: CALL_HEAP_FUNCTION(isolate, object->DeleteElement(index,
mode), Object);
What about just calling into the handlified version here?

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5182
src/objects.cc:5182: return JSProxy::cast(this)->DeleteElementWithHandler(index,
mode);
I'd keep this one handlified.

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5184
src/objects.cc:5184: return JSObject::cast(this)->DeleteElement(index, mode);
... and use CALL_HEAP_FUNCTION here.

[Michael Starzinger, 2013-07-16 11:37:41]

Addressed comments. PTAL.

https://codereview.chromium.org/18774002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode716
src/objects.cc:716: Handle<NameDictionary> dictionary =
handle(object->property_dictionary());
On 2013/07/12 12:37:34, Toon Verwaest wrote:
> What about just Handle<NameDictionary>
dictionary(object->property_dictonary())?

Done.

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode3551
src/objects.cc:3551: return *JSProxy::DeletePropertyWithHandler(object, name,
mode);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
> It seems a bit scary to call from non-handlified code into handlified code.
Can
> we get rid of this method altogether and make its caller also handlified?

Done.

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5131
src/objects.cc:5131: CALL_HEAP_FUNCTION(isolate, object->DeleteElement(index,
mode), Object);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
> What about just calling into the handlified version here?

Done.

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5182
src/objects.cc:5182: return JSProxy::cast(this)->DeleteElementWithHandler(index,
mode);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
> I'd keep this one handlified.

Done.

https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5184
src/objects.cc:5184: return JSObject::cast(this)->DeleteElement(index, mode);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
> ... and use CALL_HEAP_FUNCTION here.

Done.

[Toon Verwaest, 2013-07-17 16:13:05]

lgtm

[Michael Starzinger, 2013-07-17 16:38:56]

Committed patchset #2 manually as r15730 (presubmit successful).