Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface

Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1877343002

Committed: https://skia.googlesource.com/skia/+/dada4dd9cf03e42369ca5b38086dba77f01a68e6

[robertphillips, 2016-04-12 14:36:49]

Description was changed from

==========
Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface
==========

to

==========
Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-12 18:08:33]

Description was changed from

==========
Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-12 18:08:33]

robertphillips@google.com changed reviewers:
+ reed@google.com, senorblanco@chromium.org, senorblanco@google.com

[Stephen White, 2016-04-12 19:06:29]

LGTM

https://codereview.chromium.org/1877343002/diff/100001/tests/ImageFilterTest.cpp
File tests/ImageFilterTest.cpp (right):

https://codereview.chromium.org/1877343002/diff/100001/tests/ImageFilterTest....
tests/ImageFilterTest.cpp:1099: // Check that a kernel that is too big for the
GPU still works
Thanks for the new test! This is an important case that I had forgotten about.

Maybe we should also add a variant with a downstream filter connected that
expects a texture-backed result (e.g., SkBlurImageFilter)? That should trigger a
re-upload.

[robertphillips, 2016-04-12 19:31:41]

https://codereview.chromium.org/1877343002/diff/100001/tests/ImageFilterTest.cpp
File tests/ImageFilterTest.cpp (right):

https://codereview.chromium.org/1877343002/diff/100001/tests/ImageFilterTest....
tests/ImageFilterTest.cpp:1099: // Check that a kernel that is too big for the
GPU still works
On 2016/04/12 19:06:28, Stephen White wrote:
> Thanks for the new test! This is an important case that I had forgotten about.
> 
> Maybe we should also add a variant with a downstream filter connected that
> expects a texture-backed result (e.g., SkBlurImageFilter)? That should trigger
a
> re-upload.

This test actually checks that, even though the big convolution occurred on the
CPU, the result we get back is texture backed. That is thanks to the pre-roll
step in filterImage.

[Stephen White, 2016-04-12 19:39:37]

On 2016/04/12 19:31:41, robertphillips wrote:
>
https://codereview.chromium.org/1877343002/diff/100001/tests/ImageFilterTest.cpp
> File tests/ImageFilterTest.cpp (right):
> 
>
https://codereview.chromium.org/1877343002/diff/100001/tests/ImageFilterTest....
> tests/ImageFilterTest.cpp:1099: // Check that a kernel that is too big for the
> GPU still works
> On 2016/04/12 19:06:28, Stephen White wrote:
> > Thanks for the new test! This is an important case that I had forgotten
about.
> > 
> > Maybe we should also add a variant with a downstream filter connected that
> > expects a texture-backed result (e.g., SkBlurImageFilter)? That should
trigger
> a
> > re-upload.
> 
> This test actually checks that, even though the big convolution occurred on
the
> CPU, the result we get back is texture backed. That is thanks to the pre-roll
> step in filterImage.

Oh right, I forgot it was no longer in filterInput(). That's fine then.

[robertphillips, 2016-04-12 21:49:51]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 21:49:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877343002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877343002/100001

[commit-bot: I haz the power, 2016-04-12 21:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:51:25]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[robertphillips, 2016-04-13 11:41:48]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 11:41:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877343002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877343002/120001

[commit-bot: I haz the power, 2016-04-13 11:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 11:50:41]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-13 11:53:29]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-13 11:53:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1877343002/#ps120001
(title: "Fix return value")

[commit-bot: I haz the power, 2016-04-13 11:53:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877343002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877343002/120001

[commit-bot: I haz the power, 2016-04-13 11:54:40]

Description was changed from

==========
Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMatrixConvolutionImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/dada4dd9cf03e42369ca5b38086dba77f01a68e6
==========

[commit-bot: I haz the power, 2016-04-13 11:54:41]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/dada4dd9cf03e42369ca5b38086dba77f01a68e6