Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1877323002: [turbofan] Generalize AllocateStub to allow old space allocation. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Generalize AllocateStub to allow old space allocation. Previously TurboFan always went to the runtime to allocate in old space, which is pretty slow compare to a stub call. R=jarin@chromium.org Committed: https://crrev.com/4aa19274cf82be836950de5434d374cbb661eb20 Cr-Commit-Position: refs/heads/master@{#35418}

Patch Set 1 #

Patch Set 2 : Go for minor key and AllocateStub #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -61 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/code-factory.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/code-stubs.h View 1 2 chunks +13 lines, -7 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 1 chunk +5 lines, -9 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 1 chunk +9 lines, -26 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-12 13:39:00 UTC) #1
Benedikt Meurer
Hey Jaro, Easy one (helps Splay) :-). Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-12 13:39:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877323002/1
4 years, 8 months ago (2016-04-12 13:40:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/10)
4 years, 8 months ago (2016-04-12 13:41:39 UTC) #6
Jarin
lgtm
4 years, 8 months ago (2016-04-12 13:50:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877323002/20001
4 years, 8 months ago (2016-04-12 13:51:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 14:12:03 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:12:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4aa19274cf82be836950de5434d374cbb661eb20
Cr-Commit-Position: refs/heads/master@{#35418}

Powered by Google App Engine
This is Rietveld 408576698