third_party/WebKit/public/platform/WebProcessMemoryDump.h - Issue 1877313003: [tracing] Track number of allocations in heap profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebProcessMemoryDump.h

Issue 1877313003: [tracing] Track number of allocations in heap profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc ('K') | « third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebProcessMemoryDump.h

diff --git a/third_party/WebKit/public/platform/WebProcessMemoryDump.h b/third_party/WebKit/public/platform/WebProcessMemoryDump.h

index 432ab947b0d9a0d11303de1f9e7ade675a2b647f..eb57e181e4b2fc58e3f9b998401db6280dd708f9 100644

--- a/third_party/WebKit/public/platform/WebProcessMemoryDump.h

+++ b/third_party/WebKit/public/platform/WebProcessMemoryDump.h

@@ -125,7 +125,7 @@ public:

// Dumps heap memory usage. |allocatorName| is used as an absolute name for

// base::trace_event::ProcessMemoryDump::AddHeapDump.

- virtual void dumpHeapUsage(const base::hash_map<base::trace_event::AllocationContext, size_t>& bytesByContext, base::trace_event::TraceEventMemoryOverhead& overhead, const char* allocatorName)

+ virtual void dumpHeapUsage(const base::hash_map<base::trace_event::AllocationContext, base::trace_event::AllocationsSizeAndCount>& metricsByContext, base::trace_event::TraceEventMemoryOverhead& overhead, const char* allocatorName)

Dmitry Skiba 2016/04/14 19:07:30 OMG long line, how did it pass presubmit check?

Primiano Tucci (use gerrit) 2016/04/14 19:37:22 Welcome to blink, where 80 col limit does not appl

{

BLINK_ASSERT_NOT_REACHED();

}