third_party/WebKit/Source/platform/web_process_memory_dump_impl.h - Issue 1877313003: [tracing] Track number of allocations in heap profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/web_process_memory_dump_impl.h

Issue 1877313003: [tracing] Track number of allocations in heap profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('K') | « third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc » ('j') | third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/web_process_memory_dump_impl.h

diff --git a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.h b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.h

index 9f16b5aceca6e5b6622edaef8042a25375b52186..42b939343315091f05d0c4aee9571713d6de8f85 100644

--- a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.h

+++ b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.h

@@ -78,8 +78,8 @@ class PLATFORM_EXPORT WebProcessMemoryDumpImpl final

base::DiscardableMemory* discardable) override;

void dumpHeapUsage(

- const base::hash_map<base::trace_event::AllocationContext, size_t>&

- bytes_by_context,

+ const base::hash_map<base::trace_event::AllocationContext, base::trace_event::AllocationsSizeAndCount>&

Dmitry Skiba 2016/04/14 19:07:30 Yup, we should typedef this monstrosity.

ssid 2016/04/14 20:17:11 Not adding as suggested by primiano.

+ metrics_by_context,

base::trace_event::TraceEventMemoryOverhead& overhead,

const char* allocator_name) override;