Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1877263002: Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. (patchset #3 id:40001 of https://codereview.chromium.org/1868963002/ ) Reason for revert: Please rebaseline: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5992 Original issue's description: > [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. > > Make these builtins fast by default w/o relying on the > %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal > with well in TurboFan (and ignition). > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg > R=epertoso@chromium.org > > Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb > Cr-Commit-Position: refs/heads/master@{#35350} > > Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c > Cr-Commit-Position: refs/heads/master@{#35402} TBR=epertoso@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e9b3e4ab9dea8041425c9aac4736e8e1b0231ab5 Cr-Commit-Position: refs/heads/master@{#35410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -622 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/builtins.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -193 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 6 chunks +0 lines, -28 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 8 chunks +2 lines, -357 lines 0 comments Download
M src/js/messages.js View 4 chunks +3 lines, -2 lines 0 comments Download
M src/js/string.js View 4 chunks +34 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan.
4 years, 8 months ago (2016-04-12 09:43:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877263002/1
4 years, 8 months ago (2016-04-12 09:43:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 09:43:59 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 09:45:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9b3e4ab9dea8041425c9aac4736e8e1b0231ab5
Cr-Commit-Position: refs/heads/master@{#35410}

Powered by Google App Engine
This is Rietveld 408576698