Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1877253003: GN: Use std::unique_ptr for owning pointers in InputFileManager. (Closed)

Created:
4 years, 8 months ago by jbroman
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, rginda+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use std::unique_ptr for owning pointers in InputFileManager. BUG=602726 Committed: https://crrev.com/959ec4e4802a64b022d7101eafbc791a0339e971 Cr-Commit-Position: refs/heads/master@{#388022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M tools/gn/input_file_manager.h View 2 chunks +3 lines, -4 lines 0 comments Download
M tools/gn/input_file_manager.cc View 5 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877253003/1
4 years, 8 months ago (2016-04-18 18:11:40 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 18:56:27 UTC) #4
jbroman
4 years, 8 months ago (2016-04-18 19:07:25 UTC) #7
brettw
lgtm
4 years, 8 months ago (2016-04-18 19:40:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877253003/1
4 years, 8 months ago (2016-04-18 21:03:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 21:08:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:10:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/959ec4e4802a64b022d7101eafbc791a0339e971
Cr-Commit-Position: refs/heads/master@{#388022}

Powered by Google App Engine
This is Rietveld 408576698