Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 1877243004: Rename Keyboard.code VolumeXXX to AudioVolumeXXX (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
garykac
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Keyboard.code VolumeXXX to AudioVolumeXXX Conform to the latest specification related to the volume key name definitions. BUG=602879 Committed: https://crrev.com/c20ce7dc62c6b92e7a827bf7856e2466f01ca38f Cr-Commit-Position: refs/heads/master@{#387049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/events/keycodes/dom/keycode_converter_data.inc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dtapuska
4 years, 8 months ago (2016-04-13 15:55:06 UTC) #3
garykac
lgtm
4 years, 8 months ago (2016-04-13 17:05:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877243004/1
4 years, 8 months ago (2016-04-13 17:51:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 18:48:27 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:49:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c20ce7dc62c6b92e7a827bf7856e2466f01ca38f
Cr-Commit-Position: refs/heads/master@{#387049}

Powered by Google App Engine
This is Rietveld 408576698