Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1877223002: Fix Environment::GetVar() result converting to UTF16. (Closed)

Created:
4 years, 8 months ago by sense (YandexTeam)
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Environment::GetVar() result converting to UTF16. Environment::GetVar() returns UTF8, but the code in GetLaunchShortcutKind() thinks that there must be ASCII. R=pkasting@chromium.org BUG=602540 Committed: https://crrev.com/41fc1171445d71c5d1d8352f3f0a021238da3638 Cr-Commit-Position: refs/heads/master@{#386919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sense (YandexTeam)
4 years, 8 months ago (2016-04-12 04:53:46 UTC) #1
Peter Kasting
LGTM
4 years, 8 months ago (2016-04-12 22:58:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877223002/1
4 years, 8 months ago (2016-04-13 04:42:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 05:41:57 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 05:43:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41fc1171445d71c5d1d8352f3f0a021238da3638
Cr-Commit-Position: refs/heads/master@{#386919}

Powered by Google App Engine
This is Rietveld 408576698