Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1877213002: Show GoogleDrive volume in saving dialog that requires naitve path. (Closed)

Created:
4 years, 8 months ago by hirono
Modified:
4 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show GoogleDrive volume in saving dialog that requires naitve path. crrev.com/376073 assumed we cannot create snapshot files for saving and it hides non-native volumes for saving dialog. However we have special hack for Google Drive to create snapshot files for saving. BUG=595503 TEST=do repro steps at the bug Committed: https://crrev.com/072c195f6a8fb12d4970b889dca8f75779b5533e Cr-Commit-Position: refs/heads/master@{#386619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hirono
PTAL, thanks!
4 years, 8 months ago (2016-04-12 03:49:58 UTC) #2
fukino
lgtm. Thank you for fixing this!
4 years, 8 months ago (2016-04-12 05:47:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877213002/1
4 years, 8 months ago (2016-04-12 07:28:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 08:05:05 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:06:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/072c195f6a8fb12d4970b889dca8f75779b5533e
Cr-Commit-Position: refs/heads/master@{#386619}

Powered by Google App Engine
This is Rietveld 408576698