[DevTools] Follow up with cleanups for InjectedScript::Scope.

third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef InjectedScript_h
 #define InjectedScript_h
 
 #include "platform/inspector_protocol/Allocator.h"
 #include "platform/inspector_protocol/TypeBuilder.h"
 #include "platform/v8_inspector/InjectedScriptNative.h"
 #include "platform/v8_inspector/InspectedContext.h"
+#include "platform/v8_inspector/V8DebuggerImpl.h"
 #include "wtf/PassOwnPtr.h"
 
 #include <v8.h>
 
 namespace blink {
 
 class InjectedScriptHost;
 class RemoteObjectId;
 class V8FunctionCall;
 class V8InspectorSessionImpl;
 
 namespace protocol {
 class DictionaryValue;
 }
 
 using protocol::Maybe;
 
 class InjectedScript final {
     PROTOCOL_DISALLOW_COPY(InjectedScript);
 public:
     static PassOwnPtr<InjectedScript> create(InspectedContext*, InjectedScriptHost*);
     ~InjectedScript();
 
+    InspectedContext* context() const { return m_context; }
+
     void getProperties(ErrorString*, v8::Local<v8::Object>, const String16& groupName, bool ownProperties, bool accessorPropertiesOnly, bool generatePreview, OwnPtr<protocol::Array<protocol::Runtime::PropertyDescriptor>>* result, Maybe<protocol::Runtime::ExceptionDetails>*);
     void releaseObject(const String16& objectId);
 
     PassOwnPtr<protocol::Runtime::RemoteObject> wrapObject(ErrorString*, v8::Local<v8::Value>, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;
     bool wrapObjectProperty(ErrorString*, v8::Local<v8::Object>, v8::Local<v8::Value> key, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;
     bool wrapPropertyInArray(ErrorString*, v8::Local<v8::Array>, v8::Local<v8::String> property, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;
     bool wrapObjectsInArray(ErrorString*, v8::Local<v8::Array>, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;
+    PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Value> table, v8::Local<v8::Value> columns) const;
 
-    PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Value> table, v8::Local<v8::Value> columns) const;
     bool findObject(ErrorString*, const RemoteObjectId&, v8::Local<v8::Value>*) const;
     String16 objectGroupName(const RemoteObjectId&) const;
     void releaseObjectGroup(const String16&);
-
     void setCustomObjectFormatterEnabled(bool);
-
-    InspectedContext* context() const { return m_context; }
-    v8::Isolate* isolate() const;
-    bool canAccessInspectedWindow() const;
-
-    bool setLastEvaluationResult(ErrorString*, v8::Local<v8::Value>);
     v8::MaybeLocal<v8::Value> resolveCallArgument(ErrorString*, protocol::Runtime::CallArgument*);
 
-    v8::MaybeLocal<v8::Object> commandLineAPI(ErrorString*) const;
-    v8::MaybeLocal<v8::Object> remoteObjectAPI(ErrorString*, const String16& groupName) const;
-
     PassOwnPtr<protocol::Runtime::ExceptionDetails> createExceptionDetails(v8::Local<v8::Message>);
     void wrapEvaluateResult(ErrorString*,
         v8::MaybeLocal<v8::Value> maybeResultValue,
         const v8::TryCatch&,
         const String16& objectGroup,
         bool returnByValue,
         bool generatePreview,
         OwnPtr<protocol::Runtime::RemoteObject>* result,
         Maybe<bool>* wasThrown,
         Maybe<protocol::Runtime::ExceptionDetails>*);
 
     class Scope {
     public:
         bool initialize();
-        void installGlobalObjectExtension(v8::MaybeLocal<v8::Object> extension);
+        bool installCommandLineAPI();
+        bool installRemoteObjectAPI(const String16& objectGroupName);
+        void ignoreExceptionsAndMuteConsole();
         v8::Local<v8::Context> context() const { return m_context; }
         InjectedScript* injectedScript() const { return m_injectedScript; }
         const v8::TryCatch& tryCatch() const { return m_tryCatch; }
 
     protected:
         Scope(ErrorString*, V8DebuggerImpl*, int contextGroupId);
         ~Scope();
         virtual void findInjectedScript(V8InspectorSessionImpl*) = 0;
 
         ErrorString* m_errorString;
         V8DebuggerImpl* m_debugger;
         int m_contextGroupId;
         InjectedScript* m_injectedScript;
 
     private:
         void cleanup();
+        V8DebuggerImpl::PauseOnExceptionsState setPauseOnExceptionsState(V8DebuggerImpl::PauseOnExceptionsState);
+        bool installGlobalObjectExtension(V8FunctionCall&);
 
         v8::HandleScope m_handleScope;
         v8::TryCatch m_tryCatch;
         v8::Local<v8::Context> m_context;
         v8::Local<v8::Symbol> m_extensionSymbol;
         v8::MaybeLocal<v8::Object> m_global;
+        bool m_ignoreExceptionsAndMuteConsole;
+        V8DebuggerImpl::PauseOnExceptionsState m_previousPauseOnExceptionsState;
     };
 
     class ContextScope: public Scope {
         PROTOCOL_DISALLOW_COPY(ContextScope);
     public:
         ContextScope(ErrorString*, V8DebuggerImpl*, int contextGroupId, int executionContextId);
         ~ContextScope();
     private:
         void findInjectedScript(V8InspectorSessionImpl*) override;
         int m_executionContextId;
@@ skipping 20 matching lines @@
         ~CallFrameScope();
         size_t frameOrdinal() const { return m_frameOrdinal; }
     private:
         void findInjectedScript(V8InspectorSessionImpl*) override;
         String16 m_remoteCallFrameId;
         size_t m_frameOrdinal;
     };
 
 private:
     InjectedScript(InspectedContext*, v8::Local<v8::Object>, PassOwnPtr<InjectedScriptNative>);
-
+    bool canAccessInspectedWindow() const;
+    bool setLastEvaluationResult(ErrorString*, v8::Local<v8::Value>);
     v8::Local<v8::Value> v8Value() const;
     v8::MaybeLocal<v8::Value> wrapValue(ErrorString*, v8::Local<v8::Value>, const String16& groupName, bool forceValueType, bool generatePreview) const;
-    v8::MaybeLocal<v8::Object> callFunctionReturnObject(ErrorString*, V8FunctionCall&) const;
 
     InspectedContext* m_context;
     v8::Global<v8::Value> m_value;
     OwnPtr<InjectedScriptNative> m_native;
 };
 
 } // namespace blink
 
 #endif