[DevTools] Follow up with cleanups for InjectedScript::Scope.

[DevTools] Follow up with cleanups for InjectedScript::Scope.

BUG=none
TBR=pfeldman@chromium.org

Committed: https://crrev.com/ff9773576b5d1c78ec942d9d737ab70780965f08
Cr-Commit-Position: refs/heads/master@{#387135}

[dgozman, 2016-04-12 18:23:37]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2016-04-12 18:23:38]

Take a look please.

[kozy, 2016-04-12 22:16:14]

https://codereview.chromium.org/1877203004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1877203004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:417: if
(!m_injectedScript || m_context.IsEmpty())
Set errorString here.

[dgozman, 2016-04-12 22:25:59]

https://codereview.chromium.org/1877203004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1877203004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:417: if
(!m_injectedScript || m_context.IsEmpty())
On 2016/04/12 22:16:13, kozyatinskiy wrote:
> Set errorString here.

Not sure. This means we call this method when initialize() has already failed.
May be not a bad thing.

[dgozman, 2016-04-13 19:20:59]

PTAL

https://codereview.chromium.org/1877203004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1877203004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:417: if
(!m_injectedScript || m_context.IsEmpty())
On 2016/04/12 22:25:59, dgozman wrote:
> On 2016/04/12 22:16:13, kozyatinskiy wrote:
> > Set errorString here.
> 
> Not sure. This means we call this method when initialize() has already failed.
> May be not a bad thing.

Added ASSERT.

[kozy, 2016-04-13 19:21:54]

lgtm

[dgozman, 2016-04-13 19:40:11]

Description was changed from

==========
[DevTools] Follow up with cleanups for InjectedScript::Scope.

BUG=none
==========

to

==========
[DevTools] Follow up with cleanups for InjectedScript::Scope.

BUG=none
TBR=pfeldman@chromium.org
==========

[dgozman, 2016-04-13 19:40:35]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-04-13 19:40:36]

TBR'ing pfeldman for blink_platform.gypi

[dgozman, 2016-04-13 19:40:41]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-04-13 19:40:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877203004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877203004/20001

[commit-bot: I haz the power, 2016-04-13 19:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 19:52:42]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[dgozman, 2016-04-13 21:08:32]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:09:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877203004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877203004/20001

[commit-bot: I haz the power, 2016-04-13 22:43:31]

Description was changed from

==========
[DevTools] Follow up with cleanups for InjectedScript::Scope.

BUG=none
TBR=pfeldman@chromium.org
==========

to

==========
[DevTools] Follow up with cleanups for InjectedScript::Scope.

BUG=none
TBR=pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-04-13 22:43:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-13 22:44:45]

Description was changed from

==========
[DevTools] Follow up with cleanups for InjectedScript::Scope.

BUG=none
TBR=pfeldman@chromium.org
==========

to

==========
[DevTools] Follow up with cleanups for InjectedScript::Scope.

BUG=none
TBR=pfeldman@chromium.org

Committed: https://crrev.com/ff9773576b5d1c78ec942d9d737ab70780965f08
Cr-Commit-Position: refs/heads/master@{#387135}
==========

[commit-bot: I haz the power, 2016-04-13 22:44:46]

Patchset 2 (id:??) landed as
https://crrev.com/ff9773576b5d1c78ec942d9d737ab70780965f08
Cr-Commit-Position: refs/heads/master@{#387135}