ios/build/bots/tryserver.chromium.mac/ios_rel_device_gn.json - Issue 1877173002: Change how MB handles goma_dir.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/build/bots/tryserver.chromium.mac/ios_rel_device_gn.json

Issue 1877173002: Change how MB handles goma_dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "owners": [	2 "owners": [

3 "dpranke",	3 "dpranke",

4 "smut"	4 "smut"

5 ],	5 ],

6 "comments": [	6 "comments": [

7 "GN + Ninja fat binary builder."	7 "GN + Ninja fat binary builder."

8 ],	8 ],

9 "xcode version": "7.0",	9 "xcode version": "7.0",

10 "GYP_DEFINES": {	10 "GYP_DEFINES": {

11 "chromium_ios_signing": "0",	11 "chromium_ios_signing": "0",

12 "gomadir": "$(gomadir)",

13 "target_subarch": "both",	12 "target_subarch": "both",

14 "use_goma": "1"	13 "use_goma": "1"

15 },	14 },

16 "gn_args": [	15 "gn_args": [

17 "goma_dir=\"$(goma_dir)\"",

18 "ios_enable_code_signing=false",	16 "ios_enable_code_signing=false",

19 "target_cpu=\"arm\"",	17 "target_cpu=\"arm\"",

20 "target_os=\"ios\"",	18 "target_os=\"ios\"",

21 "use_goma=true"	19 "use_goma=true"

22 ],	20 ],

23 "mb_type": "gn",	21 "mb_type": "gn",

24 "compiler": "ninja",	22 "compiler": "ninja",

25 "configuration": "Release",	23 "configuration": "Release",

26 "sdk": "iphoneos9.0",	24 "sdk": "iphoneos9.0",

27 "tests": [	25 "tests": [

28 ]	26 ]

29 }	27 }

OLD	NEW