Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1877153003: mash: Fix crashes during chrome teardown. (Closed)

Created:
4 years, 8 months ago by sadrul
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, jam, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Fix crashes during chrome teardown. On ChromeOS, when running as a mus client, the browser does not initialize AccessibilityManager and MagnificationManager. So avoid trying to shutdown these systems during tear-down. Also, MojoShellConnection is initialized before the various impls of BrowserMainParts::PreMainMessageLoopRun(). There, defer the destruction of MojoShellConnection until BrowserMainParts::PostMainMessageLoopRun() impls are run. BUG=601983 Committed: https://crrev.com/dd641a00bc5eb5401cfab3f3ae6a92439241424f Cr-Commit-Position: refs/heads/master@{#387171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sadrul
rockot@ Can you please check to see if the change in teardown order can affect ...
4 years, 8 months ago (2016-04-12 22:49:30 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-12 23:22:42 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-13 21:32:37 UTC) #4
sadrul
+ben@ for owner stamp for the change in content/
4 years, 8 months ago (2016-04-13 21:37:52 UTC) #6
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-13 21:41:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877153003/1
4 years, 8 months ago (2016-04-13 23:37:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 00:33:26 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 00:34:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd641a00bc5eb5401cfab3f3ae6a92439241424f
Cr-Commit-Position: refs/heads/master@{#387171}

Powered by Google App Engine
This is Rietveld 408576698