Reland: Switch components/password_manager code from IPC messages to Mojo.

Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking GPU Linux Builder after landed..
Fix chrome/browser/BUILD.gn and reland.

The original CL:
https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391
TBR=vabr@chromium.org,rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/952ea3256d245d6b7f6bd797d6c4304b2c2b7d71
Cr-Commit-Position: refs/heads/master@{#386904}

[leonhsl(Using Gerrit), 2016-04-12 05:40:06]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 05:40:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877123003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877123003/1

[leonhsl(Using Gerrit), 2016-04-12 05:42:22]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 05:42:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877123003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877123003/20001

[commit-bot: I haz the power, 2016-04-12 05:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 05:52:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-12 07:39:21]

leon.han@intel.com changed reviewers:
+ jochen@chromium.org, rockot@chromium.org, tsepez@chromium.org,
vabr@chromium.org

[leonhsl(Using Gerrit), 2016-04-12 07:39:22]

Hi, I really hesitated to add all of you again for review,  but to land this CL
I have to do so~ Sorry to bring the additional works to all of you..

ps#1: is identical with original CL
ps#2: fix chrome/browser/BUILD.gn

As for ps#1, reproduced build failure by running "ninja -C out/Release
chrome/browser:test_support_ui" in my local machine, and, after fix, confirmed
ps#2 can succeed.

[leonhsl(Using Gerrit), 2016-04-12 07:54:52]

leon.han@intel.com changed reviewers:
+ fs@opera.com

[leonhsl(Using Gerrit), 2016-04-12 07:54:53]

"ninja -C out/Release chrome/browser:test_support_ui" is the root cause of the
GPU Linux Builder failure which caused the original CL be reverted.
https://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/buil...


Although I've confirmed ps#2 is OK in my local machine, I have no idea how to
confirm on the GPU Linux Builder trybot, would you please help for this if
possible? If we can do so, we can make sure ps#2 is 100% OK..
+ps@ , any hint for this? Thanks in advance~

[vabr (Chromium), 2016-04-12 08:19:36]

On 2016/04/12 07:54:53, leonhsl wrote:
> "ninja -C out/Release chrome/browser:test_support_ui" is the root cause of the
> GPU Linux Builder failure which caused the original CL be reverted.
>
https://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/buil...
> 
> 
> Although I've confirmed ps#2 is OK in my local machine, I have no idea how to
> confirm on the GPU Linux Builder trybot, would you please help for this if
> possible? If we can do so, we can make sure ps#2 is 100% OK..
> +ps@ , any hint for this? Thanks in advance~

Thanks for the fix and all due diligence, including the local verification of
the fix, and making it easy to see the difference against the reverted change.

As for reviews, you need jochen@ for //chrome/browser/BUILD.gn, the rest can be
TBR-ed because it did not change since the last approval.

As for the bot, the only linux one with GPU in the name I found was
linux_optional_gpu_tests_rel, let's see how that one ends up doing. But if you
were able to reproduce the failure locally and then verify that the fix works,
that should be enough.

Cheers and LGTM,
Vaclav

[fs, 2016-04-12 08:26:20]

On 2016/04/12 at 08:19:36, vabr wrote:
> On 2016/04/12 07:54:53, leonhsl wrote:
> > "ninja -C out/Release chrome/browser:test_support_ui" is the root cause of
the
> > GPU Linux Builder failure which caused the original CL be reverted.
> >
https://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/buil...
> > 
> > 
> > Although I've confirmed ps#2 is OK in my local machine, I have no idea how
to
> > confirm on the GPU Linux Builder trybot, would you please help for this if
> > possible? If we can do so, we can make sure ps#2 is 100% OK..
> > +ps@ , any hint for this? Thanks in advance~
> 
> Thanks for the fix and all due diligence, including the local verification of
the fix, and making it easy to see the difference against the reverted change.
> 
> As for reviews, you need jochen@ for //chrome/browser/BUILD.gn, the rest can
be TBR-ed because it did not change since the last approval.
> 
> As for the bot, the only linux one with GPU in the name I found was
linux_optional_gpu_tests_rel, let's see how that one ends up doing. But if you
were able to reproduce the failure locally and then verify that the fix works,
that should be enough.

FWIW, IIRC the build failed on bots other than "GPU Linux Builder" (ISTR at
least one of the non-GPU Linux bots on the waterfall had the same error). So,
probably no need to chase that particular herring. I agree with what vabr said
above.

[vabr (Chromium), 2016-04-12 08:30:50]

> > As for the bot, the only linux one with GPU in the name I found was
> linux_optional_gpu_tests_rel, let's see how that one ends up doing. But if you
> were able to reproduce the failure locally and then verify that the fix works,
> that should be enough.
> 
The bot is failing currently, but due to
https://chromium.googlesource.com/chromium/src/+/7b01a0867be0895009b120f37fcd....
I'm reverting that one, and we should try again afterwards.

[leonhsl(Using Gerrit), 2016-04-12 09:20:43]

On 2016/04/12 08:30:50, vabr (Chromium) wrote:
> > > As for the bot, the only linux one with GPU in the name I found was
> > linux_optional_gpu_tests_rel, let's see how that one ends up doing. But if
you
> > were able to reproduce the failure locally and then verify that the fix
works,
> > that should be enough.
> > 
> The bot is failing currently, but due to
>
https://chromium.googlesource.com/chromium/src/+/7b01a0867be0895009b120f37fcd....
> I'm reverting that one, and we should try again afterwards.

Hi, Thanks a lot for great support~  Now I know what's the usage of TBR ;-)

[vabr (Chromium), 2016-04-12 09:29:15]

On 2016/04/12 09:20:43, leonhsl wrote:
> On 2016/04/12 08:30:50, vabr (Chromium) wrote:
> > > > As for the bot, the only linux one with GPU in the name I found was
> > > linux_optional_gpu_tests_rel, let's see how that one ends up doing. But if
> you
> > > were able to reproduce the failure locally and then verify that the fix
> works,
> > > that should be enough.
> > > 
> > The bot is failing currently, but due to
> >
>
https://chromium.googlesource.com/chromium/src/+/7b01a0867be0895009b120f37fcd....
> > I'm reverting that one, and we should try again afterwards.
> 
> Hi, Thanks a lot for great support~  Now I know what's the usage of TBR ;-)

The usage of TBR is specified in
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review....
It actually does not mention this case. I'll bring it up on chromium-dev (but
still think it is reasonable to TBR here after you have the OWNERS review for
the BUILD.gn change).

Given what fs@ wrote about failures outside of GPU as well, I suggest landing
this as soon as you have the approval for the changed BUILD.gn. In the meantime,
the gpu trybot passed build file analysis anyway.

Cheers,
Vaclav

[leonhsl(Using Gerrit), 2016-04-12 09:57:13]

Description was changed from

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking GPU Linux Builder after landed..
Fix chrome/browser/BUILD.gn and reland.

The original CL:
https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391
==========

to

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking GPU Linux Builder after landed..
Fix chrome/browser/BUILD.gn and reland.

The original CL:
https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391

TBR=vabr@chromium.org,rockot@chromium.org,tsepez@chromium.org
==========

[leonhsl(Using Gerrit), 2016-04-12 09:58:51]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 09:59:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877123003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877123003/20001

[leonhsl(Using Gerrit), 2016-04-12 10:03:36]

On 2016/04/12 09:29:15, vabr (Chromium) wrote:
> On 2016/04/12 09:20:43, leonhsl wrote:
> > On 2016/04/12 08:30:50, vabr (Chromium) wrote:
> > > > > As for the bot, the only linux one with GPU in the name I found was
> > > > linux_optional_gpu_tests_rel, let's see how that one ends up doing. But
if
> > you
> > > > were able to reproduce the failure locally and then verify that the fix
> > works,
> > > > that should be enough.
> > > > 
> > > The bot is failing currently, but due to
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/7b01a0867be0895009b120f37fcd....
> > > I'm reverting that one, and we should try again afterwards.
> > 
> > Hi, Thanks a lot for great support~  Now I know what's the usage of TBR ;-)
> 
> The usage of TBR is specified in
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review....
> It actually does not mention this case. I'll bring it up on chromium-dev (but
> still think it is reasonable to TBR here after you have the OWNERS review for
> the BUILD.gn change).
> 
> Given what fs@ wrote about failures outside of GPU as well, I suggest landing
> this as soon as you have the approval for the changed BUILD.gn. In the
meantime,
> the gpu trybot passed build file analysis anyway.
> 
> Cheers,
> Vaclav

Got it, Big thanks ;-) 
I've added TBR into cl description, but 'chromium_presubmit' is still failing,
even got OK from jochen@, seems we still need //mojo and //ipc OWNERs approval
to pass 'chromium_presubmit'? Thanks~

[commit-bot: I haz the power, 2016-04-12 10:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 10:04:09]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-04-12 10:18:17]

On 2016/04/12 10:03:36, leonhsl wrote:
> On 2016/04/12 09:29:15, vabr (Chromium) wrote:
> > On 2016/04/12 09:20:43, leonhsl wrote:
> > > On 2016/04/12 08:30:50, vabr (Chromium) wrote:
> > > > > > As for the bot, the only linux one with GPU in the name I found was
> > > > > linux_optional_gpu_tests_rel, let's see how that one ends up doing.
But
> if
> > > you
> > > > > were able to reproduce the failure locally and then verify that the
fix
> > > works,
> > > > > that should be enough.
> > > > > 
> > > > The bot is failing currently, but due to
> > > >
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/7b01a0867be0895009b120f37fcd....
> > > > I'm reverting that one, and we should try again afterwards.
> > > 
> > > Hi, Thanks a lot for great support~  Now I know what's the usage of TBR
;-)
> > 
> > The usage of TBR is specified in
> >
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review....
> > It actually does not mention this case. I'll bring it up on chromium-dev
(but
> > still think it is reasonable to TBR here after you have the OWNERS review
for
> > the BUILD.gn change).
> > 
> > Given what fs@ wrote about failures outside of GPU as well, I suggest
landing
> > this as soon as you have the approval for the changed BUILD.gn. In the
> meantime,
> > the gpu trybot passed build file analysis anyway.
> > 
> > Cheers,
> > Vaclav
> 
> Got it, Big thanks ;-) 
> I've added TBR into cl description, but 'chromium_presubmit' is still failing,
> even got OK from jochen@, seems we still need //mojo and //ipc OWNERs approval
> to pass 'chromium_presubmit'? Thanks~

I don't see an approval from jochen@ here yet, please wait until he approves.
After that you should be OK with your current set of TBRs.

Cheers,
Vaclav

[Tom Sepez, 2016-04-12 16:28:55]

lgtm

[jochen (gone - plz use gerrit), 2016-04-12 18:50:52]

lgtm

[leonhsl(Using Gerrit), 2016-04-13 00:21:11]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2016-04-13 00:21:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877123003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877123003/20001

[commit-bot: I haz the power, 2016-04-13 00:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 00:29:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-13 00:38:33]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2016-04-13 00:38:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877123003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877123003/20001

[commit-bot: I haz the power, 2016-04-13 00:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 00:46:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-13 00:58:59]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2016-04-13 00:59:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jochen@chromium.org, vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1877123003/#ps40001
(title: "Rebase only")

[commit-bot: I haz the power, 2016-04-13 00:59:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877123003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877123003/40001

[commit-bot: I haz the power, 2016-04-13 02:45:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 02:46:30]

Description was changed from

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking GPU Linux Builder after landed..
Fix chrome/browser/BUILD.gn and reland.

The original CL:
https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391

TBR=vabr@chromium.org,rockot@chromium.org,tsepez@chromium.org
==========

to

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking GPU Linux Builder after landed..
Fix chrome/browser/BUILD.gn and reland.

The original CL:
https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391

TBR=vabr@chromium.org,rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/952ea3256d245d6b7f6bd797d6c4304b2c2b7d71
Cr-Commit-Position: refs/heads/master@{#386904}
==========

[commit-bot: I haz the power, 2016-04-13 02:46:32]

Patchset 3 (id:??) landed as
https://crrev.com/952ea3256d245d6b7f6bd797d6c4304b2c2b7d71
Cr-Commit-Position: refs/heads/master@{#386904}