Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1877093002: Update PaintLayer::needsPaintPhaseXXX flags when add/remove layer on style change (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Update PaintLayer::needsPaintPhaseXXX flags when add/remove layer on style change When addding/removing a layer on style change, we may not do paint invalidation to update the needsPaintPhaseXXX flags, so we need to update the flags manually. In the future, the logic can be simplified by updating the flags during pre-painting tree walk. BUG=598978 Review URL: https://codereview.chromium.org/1862313002 Cr-Commit-Position: refs/heads/master@{#386264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 4 chunks +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 3 chunks +30 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/README.md View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Xianzhu
4 years, 8 months ago (2016-04-11 23:17:45 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
e18b750ff0b6bde3e4d74a6924e2b587f525a87f.

Powered by Google App Engine
This is Rietveld 408576698