Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1877083003: buildbucket: add retry API. (Closed)

Created:
4 years, 8 months ago by nodir
Modified:
4 years, 8 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

buildbucket: add retry API. Add retry API that schedules a build with same bucket, parameters and tags. Add retry_of build attribute. Add retry_of filter to search. If specified, buckets are parameters are optinoal. R=vadimsh@chromium.org BUG=601241 Committed: https://chromium.googlesource.com/infra/infra/+/03fc01f1544e23e6583e27c33482ba26f376118b

Patch Set 1 #

Total comments: 2

Patch Set 2 : add retry_of tag #

Total comments: 2

Patch Set 3 : retry_of as an attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -7 lines) Patch
M appengine/cr-buildbucket/api.py View 1 2 5 chunks +29 lines, -1 line 0 comments Download
M appengine/cr-buildbucket/model.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/cr-buildbucket/service.py View 1 2 9 chunks +31 lines, -4 lines 0 comments Download
M appengine/cr-buildbucket/test/api_test.py View 1 2 5 chunks +48 lines, -2 lines 0 comments Download
M appengine/cr-buildbucket/test/service_test.py View 1 2 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
nodir
PTAL
4 years, 8 months ago (2016-04-11 23:21:28 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/1877083003/diff/1/appengine/cr-buildbucket/service.py File appengine/cr-buildbucket/service.py (right): https://codereview.chromium.org/1877083003/diff/1/appengine/cr-buildbucket/service.py#newcode192 appengine/cr-buildbucket/service.py:192: return add( does it make sense to add ...
4 years, 8 months ago (2016-04-11 23:30:10 UTC) #2
nodir
https://codereview.chromium.org/1877083003/diff/1/appengine/cr-buildbucket/service.py File appengine/cr-buildbucket/service.py (right): https://codereview.chromium.org/1877083003/diff/1/appengine/cr-buildbucket/service.py#newcode192 appengine/cr-buildbucket/service.py:192: return add( On 2016/04/11 23:30:10, Vadim Sh. wrote: > ...
4 years, 8 months ago (2016-04-11 23:57:36 UTC) #3
Vadim Sh.
https://codereview.chromium.org/1877083003/diff/20001/appengine/cr-buildbucket/service.py File appengine/cr-buildbucket/service.py (right): https://codereview.chromium.org/1877083003/diff/20001/appengine/cr-buildbucket/service.py#newcode194 appengine/cr-buildbucket/service.py:194: tags=build.tags + ['retry_of:%s' % build_id], well.. if you want ...
4 years, 8 months ago (2016-04-12 00:02:14 UTC) #4
nodir
https://codereview.chromium.org/1877083003/diff/20001/appengine/cr-buildbucket/service.py File appengine/cr-buildbucket/service.py (right): https://codereview.chromium.org/1877083003/diff/20001/appengine/cr-buildbucket/service.py#newcode194 appengine/cr-buildbucket/service.py:194: tags=build.tags + ['retry_of:%s' % build_id], On 2016/04/12 00:02:13, Vadim ...
4 years, 8 months ago (2016-04-12 13:32:43 UTC) #8
Vadim Sh.
lgtm
4 years, 8 months ago (2016-04-12 17:50:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877083003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877083003/80001
4 years, 8 months ago (2016-04-13 15:34:35 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 15:38:56 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/03fc01f1544e23e6583e27c33482b...

Powered by Google App Engine
This is Rietveld 408576698