components/sync_sessions/sessions_sync_manager.h - Issue 1877083002: [Sync] Moved tab_node_id tracking to session object and improved foreign session garbage collection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_sessions/sessions_sync_manager.h

Issue 1877083002: [Sync] Moved tab_node_id tracking to session object and improved foreign session garbage collection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing comment for zea. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc ('k') | components/sync_sessions/sessions_sync_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_sessions/sessions_sync_manager.h

diff --git a/components/sync_sessions/sessions_sync_manager.h b/components/sync_sessions/sessions_sync_manager.h

index ba48b24be1661994fcd1646c81c04e1f6d7effd1..dcce6b0e88f817e5b0f755c42eebfcd581502f63 100644

--- a/components/sync_sessions/sessions_sync_manager.h

+++ b/components/sync_sessions/sessions_sync_manager.h

@@ -160,6 +160,10 @@ class SessionsSyncManager : public syncer::SyncableService,

FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, BlockedNavigations);

FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, DeleteForeignSession);

FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest,

+ ProcessForeignDeleteTabsWithShadowing);

+ FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest,

+ ProcessForeignDeleteTabsWithReusedNodeIds);

+ FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest,

SaveUnassociatedNodesForReassociation);

FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, MergeDeletesCorruptNode);

FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest,

@@ -342,7 +346,7 @@ class SessionsSyncManager : public syncer::SyncableService,

// Number of days without activity after which we consider a session to be

// stale and a candidate for garbage collection.

- size_t stale_session_threshold_days_;

+ int stale_session_threshold_days_;

scoped_ptr<LocalSessionEventRouter> local_event_router_;