chrome/browser/sync/glue/session_sync_test_helper.cc - Issue 1877083002: [Sync] Moved tab_node_id tracking to session object and improved foreign session garbage collection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/session_sync_test_helper.cc

Issue 1877083002: [Sync] Moved tab_node_id tracking to session object and improved foreign session garbage collection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing comment for zea. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/session_sync_test_helper.h ('k') | chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/session_sync_test_helper.cc

diff --git a/chrome/browser/sync/glue/session_sync_test_helper.cc b/chrome/browser/sync/glue/session_sync_test_helper.cc

index e3a9f560d8e39868fac0daab5aa6f06488a66403..34f2dd2a814b5bc0d8cf5d239f2f8c722ae61284 100644

--- a/chrome/browser/sync/glue/session_sync_test_helper.cc

+++ b/chrome/browser/sync/glue/session_sync_test_helper.cc

@@ -98,8 +98,17 @@ void SessionSyncTestHelper::BuildTabSpecifics(

int window_id,

int tab_id,

sync_pb::SessionSpecifics* tab_base) {

+ BuildTabSpecifics(tag, window_id, tab_id, ++max_tab_node_id_, tab_base);

+void SessionSyncTestHelper::BuildTabSpecifics(

+ const std::string& tag,

+ int window_id,

+ int tab_id,

+ int tab_node_id,

+ sync_pb::SessionSpecifics* tab_base) {

tab_base->set_session_tag(tag);

- tab_base->set_tab_node_id(++max_tab_node_id_);

+ tab_base->set_tab_node_id(tab_node_id);

sync_pb::SessionTab* tab = tab_base->mutable_tab();

tab->set_tab_id(tab_id);

tab->set_tab_visual_index(1);