[Sync] Moved tab_node_id tracking to session object and improved foreign session garbage collection.

chrome/browser/sync/glue/session_sync_test_helper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SESSION_SYNC_TEST_HELPER_H_
 #define CHROME_BROWSER_SYNC_GLUE_SESSION_SYNC_TEST_HELPER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 24 matching lines @@
   static void VerifySyncedSession(
       const std::string& tag,
       const std::vector<std::vector<SessionID::id_type>>& windows,
       const sync_driver::SyncedSession& session);
 
   void BuildTabSpecifics(const std::string& tag,
                          int window_id,
                          int tab_id,
                          sync_pb::SessionSpecifics* tab_base);
 
+  void BuildTabSpecifics(const std::string& tag,

[Nicolas Zea, 2016/04/12 20:38:03]

This entire file should really have comments, but at least could we add some
distinguishing this method from the one above?

[skym, 2016/04/12 22:12:14]

Done.

+                         int window_id,
+                         int tab_id,
+                         int tab_node_id,
+                         sync_pb::SessionSpecifics* tab_base);
+
   sync_pb::SessionSpecifics BuildForeignSession(
       const std::string& tag,
       const std::vector<SessionID::id_type>& tab_list,
       std::vector<sync_pb::SessionSpecifics>* tabs);
 
   void Reset();
 
  private:
   int max_tab_node_id_;
 
   DISALLOW_COPY_AND_ASSIGN(SessionSyncTestHelper);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SESSION_SYNC_TEST_HELPER_H_