Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1877073004: Move the grid shorthand into CSSPropertyParser (Closed)

Created:
4 years, 8 months ago by rwlbuis
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the grid shorthand into CSSPropertyParser Move the grid shorthand from LegacyCSSPropertyParser into CSSPropertyParser. This CL also moves the remaining methods out of LegacyCSSPropertyParser.cpp and deletes it. BUG=499780 Committed: https://crrev.com/5d14b507fcd9a1d4af9d2c7b96edb20e7c7b7414 Cr-Commit-Position: refs/heads/master@{#387225}

Patch Set 1 #

Total comments: 28

Patch Set 2 : Address most review comments #

Patch Set 3 : Address all review comments #

Patch Set 4 : Fix logic err #

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -308 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 5 chunks +2 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 7 chunks +221 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 chunk +0 lines, -273 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
rwlbuis
PTAL. I can do the moving helpers/removal of LegacyCSSPropertyParser.cpp in a later patch if you ...
4 years, 8 months ago (2016-04-12 20:17:16 UTC) #3
Timothy Loh
https://codereview.chromium.org/1877073004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1877073004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode63 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:63: void CSSPropertyParser::addProperty(CSSPropertyID propId, CSSValue* value, bool important, bool implicit) ...
4 years, 8 months ago (2016-04-13 06:09:42 UTC) #4
rwlbuis
PTAL (assuming it goes green). https://codereview.chromium.org/1877073004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1877073004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode63 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:63: void CSSPropertyParser::addProperty(CSSPropertyID propId, CSSValue* ...
4 years, 8 months ago (2016-04-13 22:16:29 UTC) #5
Timothy Loh
lgtm https://codereview.chromium.org/1877073004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1877073004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode3150 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3150: ASSERT(value->isPrimitiveValue() || (value->isFunctionValue() && toCSSFunctionValue(*value).item(0))); On 2016/04/13 22:16:29, ...
4 years, 8 months ago (2016-04-14 02:04:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877073004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877073004/80001
4 years, 8 months ago (2016-04-14 02:22:42 UTC) #9
rwlbuis
On 2016/04/14 02:04:12, Timothy Loh wrote: > Not sure I follow. Ternary below says: > ...
4 years, 8 months ago (2016-04-14 02:24:58 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-14 03:32:18 UTC) #12
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/5d14b507fcd9a1d4af9d2c7b96edb20e7c7b7414 Cr-Commit-Position: refs/heads/master@{#387225}
4 years, 8 months ago (2016-04-14 03:34:06 UTC) #14
Timothy Loh
On 2016/04/14 02:24:58, rwlbuis wrote: > Once this is in, what is left? Do you ...
4 years, 8 months ago (2016-04-14 03:38:46 UTC) #15
rwlbuis
4 years, 8 months ago (2016-04-14 16:54:57 UTC) #16
Message was sent while issue was closed.
On 2016/04/14 03:38:46, Timothy Loh wrote:
> On 2016/04/14 02:24:58, rwlbuis wrote:
> > Once this is in, what is left? Do you want to make a patch removing
> > CSSParserValues.*? And there is also the parseValueStart TODO.
> 
> Feel free to remove CSSParserValues. I think we can remove
> ShorthandScope/m_inParseShorthand and just set m_currentShorthand instead in
the
> one place it's used. There's a bunch of other stuff that I'm thinking of but..
I
> need to actually check that any of it makes sense first. When I have time I'll
> probably scroll through the entire property parser and make some clean-ups.
> 
> But yeah, once CSSParserValues is removed I think we can close the bug and
call
> this finished.

Sounds good, I put that CSSParserValues removal patch up here:
https://codereview.chromium.org/1883983003/

Powered by Google App Engine
This is Rietveld 408576698