content/browser/frame_host/interstitial_page_impl_browsertest.cc - Issue 1877073003: Respect the order of input messages from browser to renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl_browsertest.cc

Issue 1877073003: Respect the order of input messages from browser to renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add DCHECKs for thread Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/interstitial_page_impl_browsertest.cc

diff --git a/content/browser/frame_host/interstitial_page_impl_browsertest.cc b/content/browser/frame_host/interstitial_page_impl_browsertest.cc

index acd83df94c3c09732e4bd2e9996a4585f0902af2..2fbdda35c986c6b0713dec2372b10bcd0c633447 100644

--- a/content/browser/frame_host/interstitial_page_impl_browsertest.cc

+++ b/content/browser/frame_host/interstitial_page_impl_browsertest.cc

@@ -53,6 +53,10 @@ class TestInterstitialPageDelegate : public InterstitialPageDelegate {

" window.domAutomationController.send("

" window.getSelection().toString());"

"}"

+ "function set_selection_change_listener() {"

+ " document.addEventListener('selectionchange',"

+ " function() { document.title='SELECTION_CHANGED'; })"

+ "}"

"</script>"

"</head>"

"<body>original body text</body>"

@@ -281,6 +285,11 @@ class InterstitialPageImplTest : public ContentBrowserTest {

"create_input_and_set_text('" + text + "')");

}

+ bool SetSelectionChangeListener() {

+ return ExecuteScript(interstitial_->GetMainFrame(),

+ "set_selection_change_listener()");

+ }

std::string PerformCut() {

clipboard_message_watcher_->InitWait();

title_update_watcher_->InitWait("TEXT_CHANGED");

@@ -310,9 +319,11 @@ class InterstitialPageImplTest : public ContentBrowserTest {

}

void PerformSelectAll() {

+ title_update_watcher_->InitWait("SELECTION_CHANGED");

RenderFrameHostImpl* rfh =

static_cast<RenderFrameHostImpl*>(interstitial_->GetMainFrame());

rfh->GetRenderWidgetHost()->delegate()->SelectAll();

+ title_update_watcher_->Wait();

}

private:

@@ -391,12 +402,14 @@ IN_PROC_BROWSER_TEST_F(InterstitialPageImplTest, Paste) {

IN_PROC_BROWSER_TEST_F(InterstitialPageImplTest, SelectAll) {

SetUpInterstitialPage();

+ ASSERT_TRUE(SetSelectionChangeListener());

std::string input_text;

ASSERT_TRUE(GetSelection(&input_text));

EXPECT_EQ(std::string(), input_text);

PerformSelectAll();

ASSERT_TRUE(GetSelection(&input_text));

EXPECT_EQ("original body text", input_text);

« no previous file with comments | « no previous file | content/browser/renderer_host/ime_adapter_android.cc » ('j') | no next file with comments »