Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1721)

Unified Diff: content/renderer/input/input_event_filter_unittest.cc

Issue 1877073003: Respect the order of input messages from browser to renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved DCHECK inside if scope Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/input_event_filter_unittest.cc
diff --git a/content/renderer/input/input_event_filter_unittest.cc b/content/renderer/input/input_event_filter_unittest.cc
index f3a9c7f79b783c62f1effd8389a2fe8e7acbff56..62e6897ba2b69ea9e3d0c42547214acec9a0ba45 100644
--- a/content/renderer/input/input_event_filter_unittest.cc
+++ b/content/renderer/input/input_event_filter_unittest.cc
@@ -178,7 +178,7 @@ TEST_F(InputEventFilterTest, Basic) {
EXPECT_EQ(0U, event_recorder_.record_count());
EXPECT_EQ(0U, message_recorder_.message_count());
- filter_->DidAddInputHandler(kTestRoutingID);
+ filter_->RegisterRoutingID(kTestRoutingID);
AddEventsToFilter(filter_.get(), kEvents, arraysize(kEvents));
ASSERT_EQ(arraysize(kEvents), ipc_sink_.message_count());
@@ -254,7 +254,7 @@ TEST_F(InputEventFilterTest, Basic) {
}
TEST_F(InputEventFilterTest, PreserveRelativeOrder) {
- filter_->DidAddInputHandler(kTestRoutingID);
+ filter_->RegisterRoutingID(kTestRoutingID);
event_recorder_.set_send_to_widget(true);
@@ -317,7 +317,7 @@ TEST_F(InputEventFilterTest, NonBlockingWheel) {
SyntheticWebMouseWheelEventBuilder::Build(30, 30, 0, 53, 1, false),
};
- filter_->DidAddInputHandler(kTestRoutingID);
+ filter_->RegisterRoutingID(kTestRoutingID);
event_recorder_.set_send_to_widget(true);
event_recorder_.set_passive(true);
@@ -395,7 +395,7 @@ TEST_F(InputEventFilterTest, NonBlockingTouch) {
kEvents[3].PressPoint(10, 10);
kEvents[3].MovePoint(0, 35, 35);
- filter_->DidAddInputHandler(kTestRoutingID);
+ filter_->RegisterRoutingID(kTestRoutingID);
event_recorder_.set_send_to_widget(true);
event_recorder_.set_passive(true);
@@ -469,7 +469,7 @@ TEST_F(InputEventFilterTest, IntermingledNonBlockingTouch) {
SyntheticWebTouchEvent kBlockingEvents[1];
kBlockingEvents[0].PressPoint(10, 10);
- filter_->DidAddInputHandler(kTestRoutingID);
+ filter_->RegisterRoutingID(kTestRoutingID);
event_recorder_.set_send_to_widget(true);
event_recorder_.set_passive(true);
AddEventsToFilter(filter_.get(), kEvents, arraysize(kEvents));

Powered by Google App Engine
This is Rietveld 408576698