Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1877073003: Respect the order of input messages from browser to renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved DCHECK inside if scope Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 SSLStatus GetSSLStatusOfFrame(blink::WebFrame* frame) const override; 438 SSLStatus GetSSLStatusOfFrame(blink::WebFrame* frame) const override;
439 const std::string& GetAcceptLanguages() const override; 439 const std::string& GetAcceptLanguages() const override;
440 #if defined(OS_ANDROID) 440 #if defined(OS_ANDROID)
441 void UpdateTopControlsState(TopControlsState constraints, 441 void UpdateTopControlsState(TopControlsState constraints,
442 TopControlsState current, 442 TopControlsState current,
443 bool animate) override; 443 bool animate) override;
444 #endif 444 #endif
445 void ConvertViewportToWindowViaWidget(blink::WebRect* rect) override; 445 void ConvertViewportToWindowViaWidget(blink::WebRect* rect) override;
446 gfx::RectF ElementBoundsInWindow(const blink::WebElement& element) override; 446 gfx::RectF ElementBoundsInWindow(const blink::WebElement& element) override;
447 float GetDeviceScaleFactorForTest() const override; 447 float GetDeviceScaleFactorForTest() const override;
448 bool HasAddedInputHandler() const override;
448 449
449 gfx::Point ConvertWindowPointToViewport(const gfx::Point& point); 450 gfx::Point ConvertWindowPointToViewport(const gfx::Point& point);
450 451
451 bool uses_temporary_zoom_level() const { return uses_temporary_zoom_level_; } 452 bool uses_temporary_zoom_level() const { return uses_temporary_zoom_level_; }
452 453
453 // Please do not add your stuff randomly to the end here. If there is an 454 // Please do not add your stuff randomly to the end here. If there is an
454 // appropriate section, add it there. If not, there are some random functions 455 // appropriate section, add it there. If not, there are some random functions
455 // nearer to the top you can add it to. 456 // nearer to the top you can add it to.
456 457
457 protected: 458 protected:
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
954 // session, this info is sent to the browser along with other drag/drop info. 955 // session, this info is sent to the browser along with other drag/drop info.
955 DragEventSourceInfo possible_drag_event_info_; 956 DragEventSourceInfo possible_drag_event_info_;
956 957
957 // NOTE: stats_collection_observer_ should be the last members because their 958 // NOTE: stats_collection_observer_ should be the last members because their
958 // constructors call the AddObservers method of RenderViewImpl. 959 // constructors call the AddObservers method of RenderViewImpl.
959 std::unique_ptr<StatsCollectionObserver> stats_collection_observer_; 960 std::unique_ptr<StatsCollectionObserver> stats_collection_observer_;
960 961
961 typedef std::map<cc::SharedBitmapId, cc::SharedBitmap*> BitmapMap; 962 typedef std::map<cc::SharedBitmapId, cc::SharedBitmap*> BitmapMap;
962 BitmapMap disambiguation_bitmaps_; 963 BitmapMap disambiguation_bitmaps_;
963 964
965 bool has_added_input_handler_;
966
964 // --------------------------------------------------------------------------- 967 // ---------------------------------------------------------------------------
965 // ADDING NEW DATA? Please see if it fits appropriately in one of the above 968 // ADDING NEW DATA? Please see if it fits appropriately in one of the above
966 // sections rather than throwing it randomly at the end. If you're adding a 969 // sections rather than throwing it randomly at the end. If you're adding a
967 // bunch of stuff, you should probably create a helper class and put your 970 // bunch of stuff, you should probably create a helper class and put your
968 // data and methods on that to avoid bloating RenderView more. You can 971 // data and methods on that to avoid bloating RenderView more. You can
969 // use the Observer interface to filter IPC messages and receive frame change 972 // use the Observer interface to filter IPC messages and receive frame change
970 // notifications. 973 // notifications.
971 // --------------------------------------------------------------------------- 974 // ---------------------------------------------------------------------------
972 975
973 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 976 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
974 }; 977 };
975 978
976 } // namespace content 979 } // namespace content
977 980
978 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 981 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698