Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187703004: Enables x-chrome-connected header for all google properties (Closed)

Created:
6 years, 9 months ago by guohui
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Enables x-chrome-connected header for all google properties BUG=348881 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255542

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/signin/signin_header_helper.cc View 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
guohui
Hey roger, could you please take a look at the CL? Thanks, Hui
6 years, 9 months ago (2014-03-05 22:54:50 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 9 months ago (2014-03-06 15:36:02 UTC) #2
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-06 18:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/187703004/40001
6 years, 9 months ago (2014-03-06 18:06:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 18:12:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 18:12:33 UTC) #6
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-06 20:13:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/187703004/40001
6 years, 9 months ago (2014-03-06 20:54:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 21:26:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 21:26:58 UTC) #10
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-07 02:09:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/187703004/40001
6 years, 9 months ago (2014-03-07 02:13:02 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 08:32:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 255542

Powered by Google App Engine
This is Rietveld 408576698