Issue 187703002: DevTools: Prepare for recursive viewport in datagrid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187703002: DevTools: Prepare for recursive viewport in datagrid (Closed)

Created:
6 years, 9 months ago by alph

Modified:
6 years, 9 months ago

Reviewers:
yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Prepare for recursive viewport in datagrid No behavioral changes, architecture only: - padding rows are moved back to the datagrid - children access are made through Node.allChildren() - minor cosmetic changes BUG=255363 R=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168480

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -72 lines)			Patch
M	Source/devtools/front_end/DataGrid.js	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotDataGrids.js	View	11 chunks	+76 lines, -46 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotGridNodes.js	View	8 chunks	+46 lines, -25 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/187703002/1

6 years, 9 months ago (2014-03-05 14:05:30 UTC) #4

alph

6 years, 9 months ago (2014-03-05 14:20:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r168480 (presubmit successful).

Expand Messages | Collapse Messages