Added a new policy setting as well as corrisponding registry key to allow GCF users the option to d…

chrome_frame/policy_settings.h

Index: chrome_frame/policy_settings.h
===================================================================
--- chrome_frame/policy_settings.h	(revision 214408)
+++ chrome_frame/policy_settings.h	(working copy)
@@ -29,6 +29,16 @@
     return default_renderer_;
   }
 
+  typedef enum PerformMetadataCheck {

[grt (UTC plus 2), 2013/08/01 19:22:57]

remove typedef here and above because they are meaningless. in c++, you can
refer to enum Foo {}; as Foo within the scope that Foo is defined. the c way of
doing things is typedef enum Foo {} Foo; so that you can refer to "enum Foo" as
just "Foo". whoever put the typedef up above in place was mistaken: there's no
need for it, and it's not correct. please don't propagate the bad style here.
thanks.

[grt (UTC plus 2), 2013/08/01 19:22:57]

Unless I'm mistaken, the polarity of this is backwards: METADATA_CHECK_YES is
interpreted in utils.cc as skipping rather than performing the check. Please
rename this to SkipMetadataCheck as I previously proposed.

[grt (UTC plus 2), 2013/08/01 19:22:57]

as mentioned before, this enum must be moved up so that it immediately follows
enum RendererForUrl above.

+      METADATA_CHECK_NOT_SPECIFIED = -1,

[grt (UTC plus 2), 2013/08/01 19:22:57]

two-space indent here rather than four.

+      METADATA_CHECK_NO,
+      METADATA_CHECK_YES,
+  };
+
+  PerformMetadataCheck metadata_check() const {
+    return metadata_check_;
+  }
+
   RendererForUrl GetRendererForUrl(const wchar_t* url);
 
   RendererForUrl GetRendererForContentType(const wchar_t* content_type);
@@ -52,6 +62,7 @@
   // Helper functions for reading settings from the registry
   static void ReadUrlSettings(RendererForUrl* default_renderer,
       std::vector<std::wstring>* renderer_exclusion_list);
+  static void ReadMetadataCheckSettings(PerformMetadataCheck* metadata_check);
   static void ReadContentTypeSetting(
       std::vector<std::wstring>* content_type_list);
   static void ReadStringSetting(const char* value_name, std::wstring* value);
@@ -60,6 +71,7 @@
  protected:
   PolicySettings()
       : default_renderer_(RENDERER_NOT_SPECIFIED),
+        metadata_check_(METADATA_CHECK_NOT_SPECIFIED),
         additional_launch_parameters_(CommandLine::NO_PROGRAM),
         suppress_turndown_prompt_(false) {
     RefreshFromRegistry();
@@ -73,6 +85,7 @@
 
  protected:
   RendererForUrl default_renderer_;
+  PerformMetadataCheck metadata_check_;
   std::vector<std::wstring> renderer_exclusion_list_;
   std::vector<std::wstring> content_type_list_;
   std::wstring application_locale_;