Issue 18770006: Remove USE_LINUX_BREAKPAD ifdef since we don't need it for chromium anymore.

Issue 18770006: Remove USE_LINUX_BREAKPAD ifdef since we don't need it for chromium anymore. (Closed)

Created:
7 years, 5 months ago by jam

Modified:
7 years, 5 months ago

Reviewers:
Lei Zhang, Nico, Sam Clegg, brettw

CC:
chromium-reviews, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove USE_LINUX_BREAKPAD ifdef since we don't need it for chromium anymore. See thread "[chromium-dev] PSA: Breakpad is now compiled into Chromium by default on Linux' for background TBR=sbc@chromium.org, thakis@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211755

Patch Set 4 : android build fix per cjhopman #

Total comments: 6

Patch Set 5 : lei's comments + sync #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -316 lines)			Patch
M	base/process/memory.h	View	1 2 3 4	2 chunks	+2 lines, -4 lines	0 comments	Download
M	base/process/memory_linux.cc	View	1 2 3 4	1 chunk	+0 lines, -4 lines	0 comments	Download
M	base/process_util_linux.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	breakpad/breakpad.gyp	View	1 2 3 4	1 chunk	+78 lines, -82 lines	0 comments	Download
M	build/all_android.gyp	View	1 2 3 4	2 chunks	+7 lines, -11 lines	0 comments	Download
M	build/common.gypi	View	1 2 3 4	4 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/app/breakpad_linux.h	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/app/chrome_main_delegate.cc	View	1 2 3 4	7 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_android.cc	View	1 2 3 4	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_linux.cc	View	1 2 3 4	6 chunks	+5 lines, -19 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 2 3 4	3 chunks	+5 lines, -6 lines	1 comment	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 2 3 4	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1 2 3 4	3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/crash_handler_host_linux.h	View	1 2 3 4	8 chunks	+2 lines, -23 lines	0 comments	Download
D	chrome/browser/crash_handler_host_linux_stub.cc	View	1 2 3 4	1 chunk	+0 lines, -82 lines	0 comments	Download
M	chrome/browser/ui/gtk/first_run_dialog.cc	View	1 2 3 4	3 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	2 chunks	+18 lines, -27 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 2 3 4	3 chunks	+6 lines, -12 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/common/dump_without_crashing.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/dump_without_crashing.cc	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

cjhopman

https://codereview.chromium.org/18770006/diff/37002/breakpad/breakpad.gyp File breakpad/breakpad.gyp (left): https://codereview.chromium.org/18770006/diff/37002/breakpad/breakpad.gyp#oldcode430 breakpad/breakpad.gyp:430: 'targets': [ merge this with 'targets' just above.

7 years, 5 months ago (2013-07-13 00:27:31 UTC) #1

Nico

chrome/ lgtm. The thread sounds like nobody knows why this define exists, and if this ...

7 years, 5 months ago (2013-07-15 17:43:36 UTC) #2

Lei Zhang

+sbc for Linux/ARM lgtm assuming sbc has no objections. A couple bits below: https://codereview.chromium.org/18770006/diff/27/build/common.gypi File ...

7 years, 5 months ago (2013-07-15 20:55:35 UTC) #3

jam

https://codereview.chromium.org/18770006/diff/27/chrome/browser/chrome_browser_main_linux.cc File chrome/browser/chrome_browser_main_linux.cc (right): https://codereview.chromium.org/18770006/diff/27/chrome/browser/chrome_browser_main_linux.cc#newcode15 chrome/browser/chrome_browser_main_linux.cc:15: #include <stdlib.h> On 2013/07/15 20:55:35, Lei Zhang wrote: > ...

7 years, 5 months ago (2013-07-15 21:15:27 UTC) #4

Sam Clegg

https://codereview.chromium.org/18770006/diff/27/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/18770006/diff/27/build/common.gypi#oldcode638 build/common.gypi:638: 'linux_breakpad%': 0, On 2013/07/15 20:55:35, Lei Zhang wrote: > ...

7 years, 5 months ago (2013-07-15 23:28:30 UTC) #5

TBR brettw for the trivial base changes

Expand Messages | Collapse Messages